Revision: 14692
http://sourceforge.net/p/skim-app/code/14692
Author: hofman
Date: 2024-11-15 18:36:33 +0000 (Fri, 15 Nov 2024)
Log Message:
-----------
make relase notes controller an ivar of app controller
Modified Paths:
--------------
trunk/SKApplicationController.h
trunk/SKApplicationController.m
trunk/SKReleaseNotesController.h
trunk/SKReleaseNotesController.m
Modified: trunk/SKApplicationController.h
===================================================================
--- trunk/SKApplicationController.h 2024-11-15 18:06:20 UTC (rev 14691)
+++ trunk/SKApplicationController.h 2024-11-15 18:36:33 UTC (rev 14692)
@@ -44,7 +44,7 @@
extern NSString *SKPageLabelsChangedNotification;
-@class SKBookmark, SKDownload;
+@class SKBookmark, SKDownload, SKReleaseNotesController;
@interface SKApplicationController : NSObject <SKApplicationDelegate,
HIDRemoteDelegate, NSMenuDelegate> {
NSMenu *noteColumnsMenu;
@@ -53,6 +53,7 @@
BOOL didCheckReopen;
BOOL remoteScrolling;
id activity;
+ SKReleaseNotesController *releaseNotesController;
}
- (IBAction)orderFrontLineInspector:(nullable id)sender;
Modified: trunk/SKApplicationController.m
===================================================================
--- trunk/SKApplicationController.m 2024-11-15 18:06:20 UTC (rev 14691)
+++ trunk/SKApplicationController.m 2024-11-15 18:36:33 UTC (rev 14692)
@@ -305,7 +305,9 @@
}
- (IBAction)showReleaseNotes:(id)sender{
- [[SKReleaseNotesController sharedReleaseNotesController] showWindow:self];
+ if (releaseNotesController == nil)
+ releaseNotesController = [[SKReleaseNotesController alloc] init];
+ [releaseNotesController showWindow:self];
}
- (IBAction)showDownloads:(id)sender{
Modified: trunk/SKReleaseNotesController.h
===================================================================
--- trunk/SKReleaseNotesController.h 2024-11-15 18:06:20 UTC (rev 14691)
+++ trunk/SKReleaseNotesController.h 2024-11-15 18:36:33 UTC (rev 14692)
@@ -46,8 +46,6 @@
@property (nonatomic, nullable, strong) IBOutlet NSTextView *textView;
-@property (class, nonatomic, readonly) SKReleaseNotesController
*sharedReleaseNotesController;
-
@end
NS_ASSUME_NONNULL_END
Modified: trunk/SKReleaseNotesController.m
===================================================================
--- trunk/SKReleaseNotesController.m 2024-11-15 18:06:20 UTC (rev 14691)
+++ trunk/SKReleaseNotesController.m 2024-11-15 18:36:33 UTC (rev 14692)
@@ -43,19 +43,6 @@
@synthesize textView;
-static SKReleaseNotesController *sharedReleaseNotesController = nil;
-
-+ (SKReleaseNotesController *)sharedReleaseNotesController {
- if (sharedReleaseNotesController == nil)
- sharedReleaseNotesController = [[self alloc] init];
- return sharedReleaseNotesController;
-}
-
-- (instancetype)init {
- if (sharedReleaseNotesController) NSLog(@"Attempt to allocate second
instance of %@", [self class]);
- return [super initWithWindowNibName:@"ReleaseNotes"];
-}
-
- (void)windowDidLoad {
[textView setString:@""];
[textView replaceCharactersInRange:[textView selectedRange]
This was sent by the SourceForge.net collaborative development platform, the
world's largest Open Source development site.
_______________________________________________
Skim-app-commit mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/skim-app-commit
