Revision: 14740
          http://sourceforge.net/p/skim-app/code/14740
Author:   hofman
Date:     2024-11-23 10:38:25 +0000 (Sat, 23 Nov 2024)
Log Message:
-----------
Don't return print error when showing print panel, because it usually is 
because of the user canceling. Unfortunately we cannot know whether this really 
is the case.

Modified Paths:
--------------
    trunk/SKDocumentController.m

Modified: trunk/SKDocumentController.m
===================================================================
--- trunk/SKDocumentController.m        2024-11-22 17:10:37 UTC (rev 14739)
+++ trunk/SKDocumentController.m        2024-11-23 10:38:25 UTC (rev 14740)
@@ -673,7 +673,7 @@
                 if (documentWasAlreadyOpen == NO)
                     [document close];
                 if (success == NO)
-                    completionHandler(NO, [NSError 
printDocumentErrorWithLocalizedDescription:[NSString 
stringWithFormat:NSLocalizedString(@"The file \"%@\" could not be printed", 
@"Error description"), [document displayName]]]);
+                    completionHandler(NO, showPrintPanels ? nil : [NSError 
printDocumentErrorWithLocalizedDescription:[NSString 
stringWithFormat:NSLocalizedString(@"The file \"%@\" could not be printed", 
@"Error description"), [document displayName]]]);
                 else if (nextURLs)
                     [self printDocumentsWithContentsOfURLs:nextURLs 
withSettings:printSettings showPrintPanels:showPrintPanels 
completionHandler:completionHandler];
                 else

This was sent by the SourceForge.net collaborative development platform, the 
world's largest Open Source development site.



_______________________________________________
Skim-app-commit mailing list
Skim-app-commit@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/skim-app-commit

Reply via email to