[Skim-app-commit] SF.net SVN: skim-app:[14954] trunk/SKMainWindow.m

[hofman--- via Skim-app-commit]

Revision: 14954
          http://sourceforge.net/p/skim-app/code/14954
Author:   hofman
Date:     2025-03-09 19:17:03 +0000 (Sun, 09 Mar 2025)
Log Message:
-----------
always change title visibility when adding or removing tab bar controller in 
compact mode

Modified Paths:
--------------
    trunk/SKMainWindow.m

Modified: trunk/SKMainWindow.m
===================================================================
--- trunk/SKMainWindow.m        2025-03-09 18:46:38 UTC (rev 14953)
+++ trunk/SKMainWindow.m        2025-03-09 19:17:03 UTC (rev 14954)
@@ -149,12 +149,14 @@
 
 - (void)addTitlebarAccessoryViewController:(NSTitlebarAccessoryViewController 
*)childViewController {
     if (@available(macOS 11.0, *)) {
-        if ([[NSUserDefaults standardUserDefaults] 
integerForKey:SKToolbarPlacementKey] == 1 && [[self toolbar] isVisible] == NO) {
-            [childViewController setLayoutAttribute:NSLayoutAttributeTop];
+        if ([[NSUserDefaults standardUserDefaults] 
integerForKey:SKToolbarPlacementKey] == 1) {
             [self setTitleVisibility:NSWindowTitleHidden];
-            NSURL *url = [self representedURL];
-            [self setRepresentedURL:nil];
-            [self setRepresentedURL:url];
+            if ([[self toolbar] isVisible] == NO) {
+                [childViewController setLayoutAttribute:NSLayoutAttributeTop];
+                NSURL *url = [self representedURL];
+                [self setRepresentedURL:nil];
+                [self setRepresentedURL:url];
+            }
         }
     }
     [super addTitlebarAccessoryViewController:childViewController];
@@ -163,11 +165,13 @@
 - (void)removeTitlebarAccessoryViewControllerAtIndex:(NSInteger)index {
     [super removeTitlebarAccessoryViewControllerAtIndex:index];
     if (@available(macOS 11.0, *)) {
-        if ([[NSUserDefaults standardUserDefaults] 
integerForKey:SKToolbarPlacementKey] == 1 && [[self toolbar] isVisible] == NO) {
+        if ([[NSUserDefaults standardUserDefaults] 
integerForKey:SKToolbarPlacementKey] == 1) {
             [self setTitleVisibility:NSWindowTitleVisible];
-            NSURL *url = [self representedURL];
-            [self setRepresentedURL:nil];
-            [self setRepresentedURL:url];
+            if ([[self toolbar] isVisible] == NO) {
+                NSURL *url = [self representedURL];
+                [self setRepresentedURL:nil];
+                [self setRepresentedURL:url];
+            }
         }
     }
 }

This was sent by the SourceForge.net collaborative development platform, the 
world's largest Open Source development site.



_______________________________________________
Skim-app-commit mailing list
Skim-app-commit@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/skim-app-commit