Revision: 15011 http://sourceforge.net/p/skim-app/code/15011 Author: hofman Date: 2025-03-24 10:00:25 +0000 (Mon, 24 Mar 2025) Log Message: ----------- check selection on the requested page first
Modified Paths: -------------- trunk/PDFAnnotationMarkup_SKExtensions.m Modified: trunk/PDFAnnotationMarkup_SKExtensions.m =================================================================== --- trunk/PDFAnnotationMarkup_SKExtensions.m 2025-03-24 09:51:47 UTC (rev 15010) +++ trunk/PDFAnnotationMarkup_SKExtensions.m 2025-03-24 10:00:25 UTC (rev 15011) @@ -119,7 +119,7 @@ - (instancetype)initSkimNoteWithSelection:(PDFSelection *)selection forPage:(PDFPage *)page forType:(NSString *)type { NSRect bounds = NSZeroRect; NSPointerArray *lines = nil; - if ([selection hasCharacters]) { + if ([selection safeIndexOfFirstCharacterOnPage:page]) { for (PDFSelection *sel in [selection connectedSelectionsOnPage:page]) { NSRect lineRect = [sel boundsForPage:page]; if (NSIsEmptyRect(lineRect) == NO && [[sel string] rangeOfCharacterFromSet:[NSCharacterSet nonWhitespaceAndNewlineCharacterSet]].length) { This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site. _______________________________________________ Skim-app-commit mailing list Skim-app-commit@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/skim-app-commit