[Skim-app-commit] SF.net SVN: skim-app:[15063] trunk/SKFontWell.m

[hofman--- via Skim-app-commit]

Revision: 15063
          http://sourceforge.net/p/skim-app/code/15063
Author:   hofman
Date:     2025-03-31 15:49:47 +0000 (Mon, 31 Mar 2025)
Log Message:
-----------
no need to seetNeedsDisplay twice

Modified Paths:
--------------
    trunk/SKFontWell.m

Modified: trunk/SKFontWell.m
===================================================================
--- trunk/SKFontWell.m  2025-03-31 15:46:46 UTC (rev 15062)
+++ trunk/SKFontWell.m  2025-03-31 15:49:47 UTC (rev 15063)
@@ -153,10 +153,6 @@
     [self deactivate];
 }
 
-- (void)dirty {
-    [self setNeedsDisplay:YES];
-}
-
 - (void)changeFontFromFontManager:(id)sender {
     if ([self isActive]) {
         NSFont *font = [sender convertFont:[self font]];
@@ -200,7 +196,6 @@
                name:NSWindowWillCloseNotification object:[fm fontPanel:YES]];
     
     [self setState:NSControlStateValueOn];
-    [self dirty];
     [self setNeedsDisplay:YES];
 }
 
@@ -207,7 +202,6 @@
 - (void)deactivate {
     [[NSNotificationCenter defaultCenter] removeObserver:self];
     [self setState:NSControlStateValueOff];
-    [self dirty];
     [self setNeedsDisplay:YES];
 }
 
@@ -299,7 +293,6 @@
 - (NSDragOperation)draggingEntered:(id <NSDraggingInfo>)sender {
     if ([self isEnabled] && [sender draggingSource] != self && [[sender 
draggingPasteboard] availableTypeFromArray:[NSArray 
arrayWithObjects:SKNSFontPanelDescriptorsPboardType, 
SKNSFontPanelFamiliesPboardType, ([self hasTextColor] ? NSPasteboardTypeColor : 
nil), nil]]) {
         [[self cell] setHighlighted:YES];
-        [self dirty];
         [self setNeedsDisplay:YES];
         return NSDragOperationGeneric;
     } else
@@ -309,7 +302,6 @@
 - (void)draggingExited:(id <NSDraggingInfo>)sender {
     if ([self isEnabled] && [sender draggingSource] != self && [[sender 
draggingPasteboard] availableTypeFromArray:[NSArray 
arrayWithObjects:SKNSFontPanelDescriptorsPboardType, 
SKNSFontPanelFamiliesPboardType, ([self hasTextColor] ? NSPasteboardTypeColor : 
nil), nil]]) {
         [[self cell] setHighlighted:NO];
-        [self dirty];
         [self setNeedsDisplay:YES];
     }
 }
@@ -363,7 +355,6 @@
     }
     
     [[self cell] setHighlighted:NO];
-    [self dirty];
     [self setNeedsDisplay:YES];
     
        return droppedFont != nil || droppedColor != nil;

This was sent by the SourceForge.net collaborative development platform, the 
world's largest Open Source development site.



_______________________________________________
Skim-app-commit mailing list
Skim-app-commit@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/skim-app-commit