Revision: 15142
          http://sourceforge.net/p/skim-app/code/15142
Author:   hofman
Date:     2025-05-02 16:14:03 +0000 (Fri, 02 May 2025)
Log Message:
-----------
No need to remember the scale as it can bbe captured by the block

Modified Paths:
--------------
    trunk/SKImageToolTipWindow.h
    trunk/SKImageToolTipWindow.m

Modified: trunk/SKImageToolTipWindow.h
===================================================================
--- trunk/SKImageToolTipWindow.h        2025-05-02 16:10:26 UTC (rev 15141)
+++ trunk/SKImageToolTipWindow.h        2025-05-02 16:14:03 UTC (rev 15142)
@@ -45,7 +45,6 @@
 @interface SKImageToolTipWindow : SKAnimatedBorderlessWindow {
     id <SKImageToolTipContext> context;
     NSPoint point;
-    CGFloat scale;
     NSImageView *imageView;
     NSImage *image;
     BOOL shouldShow;

Modified: trunk/SKImageToolTipWindow.m
===================================================================
--- trunk/SKImageToolTipWindow.m        2025-05-02 16:10:26 UTC (rev 15141)
+++ trunk/SKImageToolTipWindow.m        2025-05-02 16:14:03 UTC (rev 15142)
@@ -163,7 +163,6 @@
 }
 
 - (void)showForImageContext:(id <SKImageToolTipContext>)aContext 
scale:(CGFloat)aScale atPoint:(NSPoint)aPoint {
-    scale = aScale;
     point = aPoint;
     
     if ([aContext isEqual:context] == NO) {
@@ -173,12 +172,13 @@
         image = nil;
         shouldShow = NO;
         
-        NSNumber *usedScaleNumber = [[NSUserDefaults standardUserDefaults] 
objectForKey:SKToolTipScaleKey];
-        CGFloat usedScale = [usedScaleNumber 
respondsToSelector:@selector(doubleValue)] ? [usedScaleNumber doubleValue] : 
DEFAULT_SCALE;
-        if (usedScale <= 0.0)
-            usedScale = usedScale < 0.0 ? fmin(scale, -usedScale) : scale;
         dispatch_async([[self class] imageQueue], ^{
             
+            NSNumber *usedScaleNumber = [[NSUserDefaults standardUserDefaults] 
objectForKey:SKToolTipScaleKey];
+            CGFloat usedScale = [usedScaleNumber 
respondsToSelector:@selector(doubleValue)] ? [usedScaleNumber doubleValue] : 
DEFAULT_SCALE;
+            if (usedScale <= 0.0)
+                usedScale = usedScale < 0.0 ? fmin(aScale, -usedScale) : 
aScale;
+            
             NSImage *anImage = [aContext toolTipImageWithScale:usedScale];
             
             dispatch_async(dispatch_get_main_queue(), ^{

This was sent by the SourceForge.net collaborative development platform, the 
world's largest Open Source development site.



_______________________________________________
Skim-app-commit mailing list
Skim-app-commit@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/skim-app-commit

Reply via email to