Revision: 15163
          http://sourceforge.net/p/skim-app/code/15163
Author:   hofman
Date:     2025-05-07 15:30:47 +0000 (Wed, 07 May 2025)
Log Message:
-----------
Always start snapshot with placeholder image and generate thumbnail async

Modified Paths:
--------------
    trunk/SKMainWindowController.m

Modified: trunk/SKMainWindowController.m
===================================================================
--- trunk/SKMainWindowController.m      2025-05-07 14:30:25 UTC (rev 15162)
+++ trunk/SKMainWindowController.m      2025-05-07 15:30:47 UTC (rev 15163)
@@ -2364,20 +2364,13 @@
     if (openType == SKSnapshotOpenPreview)
         return;
     
-    NSImage *image;
     BOOL isVisible = [self rightSidePaneIsOpen] && [self rightSidePaneState] 
== SKSidePaneStateSnapshot;
     CGFloat scale = [[self window] backingScaleFactor];
+    NSImage *image = [controller 
placeholderThumbnailWithSize:snapshotCacheSize scale:scale];
     
-    if (isVisible && openType == SKSnapshotOpenNormal)
-        image = [[controller currentConfiguration] 
thumbnailWithSize:snapshotCacheSize scale:scale];
-    else
-        image = [controller placeholderThumbnailWithSize:snapshotCacheSize 
scale:scale];
-    
     [controller setThumbnail:image];
+    [self snapshotNeedsUpdate:controller placeholder:YES];
     
-    if (isVisible == NO || openType != SKSnapshotOpenNormal)
-        [self snapshotNeedsUpdate:controller placeholder:YES];
-    
     if (openType == SKSnapshotOpenFromSetup) {
         [self insertObject:controller inSnapshotsAtIndex:[snapshots count]];
         [rightSideController.snapshotTableView reloadData];

This was sent by the SourceForge.net collaborative development platform, the 
world's largest Open Source development site.



_______________________________________________
Skim-app-commit mailing list
Skim-app-commit@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/skim-app-commit

Reply via email to