Revision: 15316 http://sourceforge.net/p/skim-app/code/15316 Author: hofman Date: 2025-05-28 09:39:56 +0000 (Wed, 28 May 2025) Log Message: ----------- use inverted boolean variable and add comment
Modified Paths: -------------- trunk/SKMainWindowController.m Modified: trunk/SKMainWindowController.m =================================================================== --- trunk/SKMainWindowController.m 2025-05-28 09:06:11 UTC (rev 15315) +++ trunk/SKMainWindowController.m 2025-05-28 09:39:56 UTC (rev 15316) @@ -1672,15 +1672,16 @@ if ([NSView shouldShowFadeAnimation] == NO) animate = NO; - BOOL isMainWindow = 0 != ([[overviewContentView window] styleMask] & NSWindowStyleMaskTitled); - NSView *newView = isMainWindow ? splitView : presentationView; - NSView *newKeyView = isMainWindow ? pdfView : presentationView; + // don't check interactionMode as this can be called from enterPresentation + BOOL isPresentation = 0 == ([[overviewContentView window] styleMask] & NSWindowStyleMaskTitled); + NSView *newView = isPresentation ? presentationView : splitView; + NSView *newKeyView = isPresentation ? presentationView : pdfView; NSView *contentView = [overviewContentView superview]; - BOOL hasStatus = isMainWindow && [statusBar isVisible]; + BOOL hasStatus = isPresentation == NO && [statusBar isVisible]; NSArray *constraints = @[ [[newView leadingAnchor] constraintEqualToAnchor:[contentView leadingAnchor]], [[contentView trailingAnchor] constraintEqualToAnchor:[newView trailingAnchor]], - [[newView topAnchor] constraintEqualToAnchor:[(mwcFlags.fullSizeContent || isMainWindow == NO ? contentView : [[contentView window] contentLayoutGuide]) topAnchor]], + [[newView topAnchor] constraintEqualToAnchor:[(mwcFlags.fullSizeContent || isPresentation ? contentView : [[contentView window] contentLayoutGuide]) topAnchor]], [(hasStatus ? [statusBar topAnchor] : [contentView bottomAnchor]) constraintEqualToAnchor:[newView bottomAnchor]]]; if (animate) { This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site. _______________________________________________ Skim-app-commit mailing list Skim-app-commit@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/skim-app-commit