Revision: 15323 http://sourceforge.net/p/skim-app/code/15323 Author: hofman Date: 2025-05-29 15:51:07 +0000 (Thu, 29 May 2025) Log Message: ----------- rename property
Modified Paths: -------------- trunk/SKMainWindowController.m trunk/SKOverviewView.h trunk/SKOverviewView.m Modified: trunk/SKMainWindowController.m =================================================================== --- trunk/SKMainWindowController.m 2025-05-29 15:42:05 UTC (rev 15322) +++ trunk/SKMainWindowController.m 2025-05-29 15:51:07 UTC (rev 15323) @@ -1634,7 +1634,7 @@ [(NSVisualEffectView *)[overviewView backgroundView] setMaterial:isPresentation ? NSVisualEffectMaterialDark : NSVisualEffectMaterialSidebar]; [[overviewView visibleItems] setValue:[NSNumber numberWithInteger:isPresentation ? NSBackgroundStyleEmphasized : NSBackgroundStyleNormal] forKey:@"backgroundStyle"]; } - [overviewView setPerformActionOnSingleClick:isPresentation]; + [overviewView setSendActionOnSingleClick:isPresentation]; [[SKImageToolTipWindow sharedToolTipWindow] orderOut:nil]; Modified: trunk/SKOverviewView.h =================================================================== --- trunk/SKOverviewView.h 2025-05-29 15:42:05 UTC (rev 15322) +++ trunk/SKOverviewView.h 2025-05-29 15:51:07 UTC (rev 15323) @@ -44,13 +44,13 @@ @interface SKOverviewView : NSCollectionView { SEL action; - BOOL performActionOnSingleClick; + BOOL sendActionOnSingleClick; SKTypeSelectHelper *typeSelectHelper; NSMutableArray *cachedViews; } @property (nonatomic) SEL action; -@property (nonatomic) BOOL performActionOnSingleClick; +@property (nonatomic) BOOL sendActionOnSingleClick; @property (nonatomic, nullable, strong) SKTypeSelectHelper *typeSelectHelper; - (nullable id)newViewWithIdentifier:(NSString *)identifier; Modified: trunk/SKOverviewView.m =================================================================== --- trunk/SKOverviewView.m 2025-05-29 15:42:05 UTC (rev 15322) +++ trunk/SKOverviewView.m 2025-05-29 15:51:07 UTC (rev 15323) @@ -49,7 +49,7 @@ @implementation SKOverviewView -@synthesize action, performActionOnSingleClick, typeSelectHelper; +@synthesize action, sendActionOnSingleClick, typeSelectHelper; - (void)keyDown:(NSEvent *)theEvent { unichar eventChar = [theEvent firstCharacter]; @@ -58,7 +58,7 @@ if ((eventChar == NSNewlineCharacter || eventChar == NSEnterCharacter || eventChar == NSCarriageReturnCharacter) && modifiers == 0 && [self action]) { [self tryToPerform:[self action] with:self]; - } else if (eventChar == 'p' && modifiers == 0 && [self performActionOnSingleClick]) { + } else if (eventChar == 'p' && modifiers == 0 && [self sendActionOnSingleClick] && [self action]) { [self tryToPerform:[self action] with:self]; } else if ((eventChar == NSDownArrowFunctionKey && standardModifiers == NSEventModifierFlagOption) || (eventChar == NSRightArrowFunctionKey && standardModifiers == NSEventModifierFlagCommand) || (eventChar == NSPageDownFunctionKey && standardModifiers == 0)) { [self tryToPerform:@selector(doGoToNextPage:) with:self]; @@ -113,7 +113,7 @@ } - (void)mouseDown:(NSEvent *)theEvent { - SEL action = (([theEvent clickCount] == 1 && [self performActionOnSingleClick]) || [theEvent clickCount] == 2) ? [self action] : NULL; + SEL action = (([theEvent clickCount] == 1 && [self sendActionOnSingleClick]) || [theEvent clickCount] == 2) ? [self action] : NULL; if (action && [NSApp willDragMouse]) action = NULL; This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site. _______________________________________________ Skim-app-commit mailing list Skim-app-commit@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/skim-app-commit