Revision: 15609
http://sourceforge.net/p/skim-app/code/15609
Author: hofman
Date: 2025-07-06 09:30:49 +0000 (Sun, 06 Jul 2025)
Log Message:
-----------
don't set undo action name during undo or redo
Modified Paths:
--------------
trunk/SKMainWindowController_Actions.m
Modified: trunk/SKMainWindowController_Actions.m
===================================================================
--- trunk/SKMainWindowController_Actions.m 2025-07-06 09:21:48 UTC (rev
15608)
+++ trunk/SKMainWindowController_Actions.m 2025-07-06 09:30:49 UTC (rev
15609)
@@ -510,7 +510,8 @@
- (void)rotatePageAtIndex:(NSUInteger)idx by:(NSInteger)rotation {
NSUndoManager *undoManager = [[self document] undoManager];
[[undoManager prepareWithInvocationTarget:self] rotatePageAtIndex:idx
by:-rotation];
- [undoManager setActionName:NSLocalizedString(@"Rotate Page", @"Undo action
name")];
+ if ([undoManager isUndoing] == NO && [undoManager isRedoing] == NO)
+ [undoManager setActionName:NSLocalizedString(@"Rotate Page", @"Undo
action name")];
[undoManager setActionIsDiscardable:YES];
PDFPage *page = [[pdfView document] pageAtIndex:idx];
@@ -523,7 +524,8 @@
- (void)rotateAllBy:(NSInteger)rotation {
NSUndoManager *undoManager = [[self document] undoManager];
[[undoManager prepareWithInvocationTarget:self] rotateAllBy:-rotation];
- [undoManager setActionName:NSLocalizedString(@"Rotate", @"Undo action
name")];
+ if ([undoManager isUndoing] == NO && [undoManager isRedoing] == NO)
+ [undoManager setActionName:NSLocalizedString(@"Rotate", @"Undo action
name")];
[undoManager setActionIsDiscardable:YES];
if (([pdfView displayMode] & kPDFDisplaySinglePageContinuous))
@@ -557,7 +559,8 @@
NSRect oldRect = [[[pdfView document] pageAtIndex:anIndex]
boundsForBox:kPDFDisplayBoxCropBox];
NSUndoManager *undoManager = [[self document] undoManager];
[[undoManager prepareWithInvocationTarget:self] cropPageAtIndex:anIndex
toRect:oldRect];
- [undoManager setActionName:NSLocalizedString(@"Crop Page", @"Undo action
name")];
+ if ([undoManager isUndoing] == NO && [undoManager isRedoing] == NO)
+ [undoManager setActionName:NSLocalizedString(@"Crop Page", @"Undo
action name")];
[undoManager setActionIsDiscardable:YES];
PDFPage *page = [[pdfView document] pageAtIndex:anIndex];
@@ -596,7 +599,8 @@
NSUndoManager *undoManager = [[self document] undoManager];
[[undoManager prepareWithInvocationTarget:self] cropPagesToRects:oldRects];
- [undoManager setActionName:NSLocalizedString(@"Crop", @"Undo action
name")];
+ if ([undoManager isUndoing] == NO && [undoManager isRedoing] == NO)
+ [undoManager setActionName:NSLocalizedString(@"Crop", @"Undo action
name")];
[undoManager setActionIsDiscardable:YES];
[[NSNotificationCenter defaultCenter]
postNotificationName:SKPDFPageBoundsDidChangeNotification
This was sent by the SourceForge.net collaborative development platform, the
world's largest Open Source development site.
_______________________________________________
Skim-app-commit mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/skim-app-commit