Revision: 15662 http://sourceforge.net/p/skim-app/code/15662 Author: hofman Date: 2025-07-15 14:53:31 +0000 (Tue, 15 Jul 2025) Log Message: ----------- don't use editedRow for voew based tables
Modified Paths: -------------- trunk/SKBookmarkController.m trunk/SKMainWindowController_UI.m Modified: trunk/SKBookmarkController.m =================================================================== --- trunk/SKBookmarkController.m 2025-07-15 14:40:21 UTC (rev 15661) +++ trunk/SKBookmarkController.m 2025-07-15 14:53:31 UTC (rev 15662) @@ -868,7 +868,8 @@ } - (void)endEditing { - if ([outlineView editedRow] && [[self window] makeFirstResponder:outlineView] == NO) + id firstResponder = [[self window] firstResponder]; + if ([firstResponder isKindOfClass:[NSText class]] && [outlineView rowForView:firstResponder] != -1 && [[self window] makeFirstResponder:outlineView] == NO) [[self window] endEditingFor:nil]; } Modified: trunk/SKMainWindowController_UI.m =================================================================== --- trunk/SKMainWindowController_UI.m 2025-07-15 14:40:21 UTC (rev 15661) +++ trunk/SKMainWindowController_UI.m 2025-07-15 14:53:31 UTC (rev 15662) @@ -1420,7 +1420,8 @@ - (BOOL)commitEditingAndReturnError:(NSError **)error { BOOL rv = [pdfView commitEditing]; - if ([rightSideController.noteOutlineView editedRow] != -1) + id firstResponder = [[self window] firstResponder]; + if ([firstResponder isKindOfClass:[NSText class]] && [rightSideController.noteOutlineView rowForView:firstResponder] != -1) rv = [[rightSideController.noteOutlineView window] makeFirstResponder:rightSideController.noteOutlineView] && rv; if (rv == NO && error) *error = [NSError failedToCommitErrorWithLocalizedDescription:NSLocalizedString(@"Failed to commit edits", @"Error description")]; This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site. _______________________________________________ Skim-app-commit mailing list Skim-app-commit@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/skim-app-commit