Revision: 15668 http://sourceforge.net/p/skim-app/code/15668 Author: hofman Date: 2025-08-17 15:34:24 +0000 (Sun, 17 Aug 2025) Log Message: ----------- service for keychain is never nil
Modified Paths: -------------- trunk/SKKeychain.h trunk/SKKeychain.m Modified: trunk/SKKeychain.h =================================================================== --- trunk/SKKeychain.h 2025-07-28 15:38:10 UTC (rev 15667) +++ trunk/SKKeychain.h 2025-08-17 15:34:24 UTC (rev 15668) @@ -50,7 +50,7 @@ + (nullable NSString *)passwordForService:(NSString *)service account:(nullable NSString *)account status:(SKPasswordStatus *)status; + (void)setPassword:(NSString *)password forService:(NSString *)service account:(NSString *)account label:(nullable NSString *)label comment:(nullable NSString *)comment; -+ (SKPasswordStatus)updatePassword:(nullable NSString *)password service:(nullable NSString *)service account:(nullable NSString *)account label:(nullable NSString *)label comment:(nullable NSString *)comment forService:(nullable NSString *)oldService account:(nullable NSString *)oldAccount; ++ (SKPasswordStatus)updatePassword:(nullable NSString *)password service:(nullable NSString *)service account:(nullable NSString *)account label:(nullable NSString *)label comment:(nullable NSString *)comment forService:(NSString *)oldService account:(nullable NSString *)oldAccount; @end Modified: trunk/SKKeychain.m =================================================================== --- trunk/SKKeychain.m 2025-07-28 15:38:10 UTC (rev 15667) +++ trunk/SKKeychain.m 2025-08-17 15:34:24 UTC (rev 15668) @@ -49,8 +49,7 @@ CFDictionarySetValue(query, kSecClass, kSecClassGenericPassword); CFDictionarySetValue(query, kSecMatchLimit, kSecMatchLimitOne); - if (service) - CFDictionarySetValue(query, kSecAttrService, (__bridge CFStringRef)service); + CFDictionarySetValue(query, kSecAttrService, (__bridge CFStringRef)service); if (account) CFDictionarySetValue(query, kSecAttrAccount, (__bridge CFStringRef)account); CFDictionarySetValue(query, kSecReturnData, kCFBooleanTrue); @@ -101,8 +100,7 @@ CFDictionarySetValue(query, kSecClass, kSecClassGenericPassword); CFDictionarySetValue(query, kSecMatchLimit, kSecMatchLimitOne); - if (itemService) - CFDictionarySetValue(query, kSecAttrService, (__bridge CFStringRef)itemService); + CFDictionarySetValue(query, kSecAttrService, (__bridge CFStringRef)itemService); if (itemAccount) CFDictionarySetValue(query, kSecAttrAccount, (__bridge CFStringRef)itemAccount); This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site. _______________________________________________ Skim-app-commit mailing list Skim-app-commit@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/skim-app-commit