Revision: 15954
http://sourceforge.net/p/skim-app/code/15954
Author: hofman
Date: 2026-01-03 19:08:09 +0000 (Sat, 03 Jan 2026)
Log Message:
-----------
don't declare find bar as alternatee UI for accessibility
Modified Paths:
--------------
trunk/PDFDocumentView_SKExtensions.m
trunk/SKMainWindowController.m
trunk/SKPDFView.m
Modified: trunk/PDFDocumentView_SKExtensions.m
===================================================================
--- trunk/PDFDocumentView_SKExtensions.m 2026-01-03 18:46:29 UTC (rev
15953)
+++ trunk/PDFDocumentView_SKExtensions.m 2026-01-03 19:08:09 UTC (rev
15954)
@@ -60,7 +60,7 @@
return enclosingPDFView([self superview]);
}
-static id pdfView(id self) {
+static id get_pdfView(id self) {
if ([self respondsToSelector:@selector(pdfView)])
return [self pdfView];
else
@@ -90,15 +90,27 @@
#pragma mark Enhanced accessibility support
static BOOL replacement_accessibilityPerformShowAlternateUI(id self, SEL _cmd)
{
- return [pdfView(self) accessibilityPerformShowAlternateUI];
+ id pdfView = get_pdfView(self);
+ if ([pdfView respondsToSelector:_cmd])
+ return [pdfView accessibilityPerformShowAlternateUI];
+ else
+ return original_accessibilityPerformShowAlternateUI(self, _cmd);
}
static BOOL replacement_accessibilityPerformShowDefaultUI(id self, SEL _cmd) {
- return [pdfView(self) accessibilityPerformShowDefaultUI];
+ id pdfView = get_pdfView(self);
+ if ([pdfView respondsToSelector:_cmd])
+ return [pdfView accessibilityPerformShowDefaultUI];
+ else
+ return original_accessibilityPerformShowDefaultUI(self, _cmd);
}
static BOOL replacement_accessibilityPerformShowMenu(id self, SEL _cmd) {
- return [pdfView(self) accessibilityPerformShowMenu];
+ id pdfView = get_pdfView(self);
+ if ([pdfView respondsToSelector:_cmd])
+ return [pdfView accessibilityPerformShowMenu];
+ else
+ return original_accessibilityPerformShowMenu(self, _cmd);
}
static BOOL replacement_annotation_accessibilityPerformPress(id self, SEL
_cmd) {
Modified: trunk/SKMainWindowController.m
===================================================================
--- trunk/SKMainWindowController.m 2026-01-03 18:46:29 UTC (rev 15953)
+++ trunk/SKMainWindowController.m 2026-01-03 19:08:09 UTC (rev 15954)
@@ -1857,10 +1857,6 @@
[contentView layoutSubtreeIfNeeded];
[window recalculateKeyViewLoop];
}
-
- id docView = NSAccessibilityUnignoredAncestor([pdfView documentView]);
- [docView setAccessibilityAlternateUIVisible:NO];
- NSAccessibilityPostNotificationWithUserInfo(docView,
NSAccessibilityLayoutChangedNotification, nil);
}
- (void)showFindBar {
@@ -1925,10 +1921,6 @@
[[self window] recalculateKeyViewLoop];
[findField selectText:nil];
}
-
- id docView = NSAccessibilityUnignoredAncestor([pdfView documentView]);
- [docView setAccessibilityAlternateUIVisible:YES];
- NSAccessibilityPostNotificationWithUserInfo(docView,
NSAccessibilityLayoutChangedNotification, [NSDictionary
dictionaryWithObjectsAndKeys:NSAccessibilityUnignoredChildrenForOnlyChild([findController
view]), NSAccessibilityUIElementsKey, nil]);
}
}
Modified: trunk/SKPDFView.m
===================================================================
--- trunk/SKPDFView.m 2026-01-03 18:46:29 UTC (rev 15953)
+++ trunk/SKPDFView.m 2026-01-03 19:08:09 UTC (rev 15954)
@@ -5113,22 +5113,6 @@
}
}
-- (BOOL)accessibilityPerformShowAlternateUI {
- if ([[self delegate] respondsToSelector:@selector(PDFViewPerformFind:)]) {
- [[self delegate] PDFViewPerformFind:self];
- return YES;
- }
- return NO;
-}
-
-- (BOOL)accessibilityPerformShowDefaultUI {
- if ([[self delegate]
respondsToSelector:@selector(PDFViewPerformHideFind:)]) {
- [[self delegate] PDFViewPerformHideFind:self];
- return YES;
- }
- return NO;
-}
-
@end
static inline PDFAreaOfInterest SKAreaOfInterestForResizeHandle(SKRectEdges
mask, PDFPage *page) {
This was sent by the SourceForge.net collaborative development platform, the
world's largest Open Source development site.
_______________________________________________
Skim-app-commit mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/skim-app-commit
