[Skim-app-commit] SF.net SVN: skim-app:[15980] trunk

[hofman--- via Skim-app-commit]

Revision: 15980
          http://sourceforge.net/p/skim-app/code/15980
Author:   hofman
Date:     2026-01-08 15:58:08 +0000 (Thu, 08 Jan 2026)
Log Message:
-----------
change displaymode when changing other display settings in cusstom setter

Modified Paths:
--------------
    trunk/SKMainToolbarController.m
    trunk/SKMainWindowController_Actions.m
    trunk/SKPDFView.m

Modified: trunk/SKMainToolbarController.m
===================================================================
--- trunk/SKMainToolbarController.m     2026-01-08 15:47:22 UTC (rev 15979)
+++ trunk/SKMainToolbarController.m     2026-01-08 15:58:08 UTC (rev 15980)
@@ -1255,17 +1255,14 @@
 - (IBAction)changeDisplayDirection:(id)sender {
     PDFDisplayDirection direction = [sender selectedTag];
     [mainController.pdfView setDisplayDirectionAndRewind:direction];
-    [mainController.pdfView setDisplayMode:kPDFDisplaySinglePageContinuous];
 }
 
 - (IBAction)changeDisplaysRTL:(id)sender {
     [mainController.pdfView setDisplaysRTLAndRewind:NO == 
[mainController.pdfView displaysRTL]];
-    [mainController.pdfView setExtendedDisplayMode:[mainController.pdfView 
displayMode] | kPDFDisplayTwoUp];
 }
 
 - (IBAction)changeBookMode:(id)sender {
     [mainController.pdfView setDisplaysAsBookAndRewind:NO == 
[mainController.pdfView displaysAsBook]];
-    [mainController.pdfView setExtendedDisplayMode:[mainController.pdfView 
displayMode] | kPDFDisplayTwoUp];
 }
 
 - (IBAction)changePageBreaks:(id)sender {

Modified: trunk/SKMainWindowController_Actions.m
===================================================================
--- trunk/SKMainWindowController_Actions.m      2026-01-08 15:47:22 UTC (rev 
15979)
+++ trunk/SKMainWindowController_Actions.m      2026-01-08 15:58:08 UTC (rev 
15980)
@@ -310,17 +310,14 @@
 
 - (IBAction)changeDisplayDirection:(id)sender {
     [pdfView setDisplayDirectionAndRewind:[sender tag]];
-    [pdfView setDisplayMode:kPDFDisplaySinglePageContinuous];
 }
 
 - (IBAction)toggleDisplaysRTL:(id)sender {
     [pdfView setDisplaysRTLAndRewind:[pdfView displaysRTL] == NO];
-    [pdfView setExtendedDisplayMode:[pdfView displayMode] | kPDFDisplayTwoUp];
 }
 
 - (IBAction)toggleDisplaysAsBook:(id)sender {
     [pdfView setDisplaysAsBookAndRewind:[pdfView displaysAsBook] == NO];
-    [pdfView setExtendedDisplayMode:[pdfView displayMode] | kPDFDisplayTwoUp];
 }
 
 - (IBAction)toggleDisplayPageBreaks:(id)sender {

Modified: trunk/SKPDFView.m
===================================================================
--- trunk/SKPDFView.m   2026-01-08 15:47:22 UTC (rev 15979)
+++ trunk/SKPDFView.m   2026-01-08 15:58:08 UTC (rev 15980)
@@ -734,6 +734,7 @@
     if (displayDirection != [self displayDirection]) {
         [self setNeedsRewind:YES];
         [self setDisplayDirection:displayDirection];
+        [self setDisplayMode:kPDFDisplaySinglePageContinuous];
     }
 }
 
@@ -750,17 +751,11 @@
     if (flag != [self displaysRTL]) {
         [self setNeedsRewind:YES];
         [self setDisplaysRTL:flag];
+        [self setDisplayMode:[self displayMode] | kPDFDisplayTwoUp];
+        [self setDisplayDirection:kPDFDisplayDirectionVertical];
     }
 }
 
-- (void)setDisplayBoxAndRewind:(PDFDisplayBox)box {
-    if (box != [self displayBox]) {
-        if ([self displayMode] != kPDFDisplaySinglePage)
-            [self setNeedsRewind:YES];
-        [self setDisplayBox:box];
-    }
-}
-
 - (void)setDisplaysAsBook:(BOOL)asBook {
     if (asBook != [self displaysAsBook]) {
         [super setDisplaysAsBook:asBook];
@@ -772,6 +767,8 @@
     if (asBook != [self displaysAsBook]) {
         [self setNeedsRewind:YES];
         [self setDisplaysAsBook:asBook];
+        [self setDisplayMode:[self displayMode] | kPDFDisplayTwoUp];
+        [self setDisplayDirection:kPDFDisplayDirectionVertical];
     }
 }
 
@@ -782,6 +779,14 @@
     }
 }
 
+- (void)setDisplayBoxAndRewind:(PDFDisplayBox)box {
+    if (box != [self displayBox]) {
+        if ([self displayMode] != kPDFDisplaySinglePage)
+            [self setNeedsRewind:YES];
+        [self setDisplayBox:box];
+    }
+}
+
 - (void)setAutoScales:(BOOL)autoScales {
     if (autoScales != [self autoScales]) {
         [super setAutoScales:autoScales];

This was sent by the SourceForge.net collaborative development platform, the 
world's largest Open Source development site.



_______________________________________________
Skim-app-commit mailing list
Skim-app-commit@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/skim-app-commit