Revision: 16365
http://sourceforge.net/p/skim-app/code/16365
Author: hofman
Date: 2026-06-07 14:32:55 +0000 (Sun, 07 Jun 2026)
Log Message:
-----------
check for canSelectNote at start of addAnnotationWithType:, will always be
valid though
Modified Paths:
--------------
trunk/SKPDFView.m
Modified: trunk/SKPDFView.m
===================================================================
--- trunk/SKPDFView.m 2026-06-06 14:30:41 UTC (rev 16364)
+++ trunk/SKPDFView.m 2026-06-07 14:32:55 UTC (rev 16365)
@@ -2629,7 +2629,10 @@
}
- (void)addAnnotationWithType:(SKNoteType)annotationType {
- if (IS_TEXT_OR_NOTE_TOOL && (annotationType == SKNoteTypeInk ||
((IS_MARKUP(annotationType) || [[NSUserDefaults standardUserDefaults]
boolForKey:SKNewNoteRequiresSelectionKey]) && [[self currentSelection]
hasCharacters] == NO))) {
+ if ([self canSelectNote] == NO) {
+ // should never happen
+ NSBeep();
+ } else if (annotationType == SKNoteTypeInk || ((IS_MARKUP(annotationType)
|| [[NSUserDefaults standardUserDefaults]
boolForKey:SKNewNoteRequiresSelectionKey]) && [[self currentSelection]
hasCharacters] == NO)) {
[self
setTemporaryToolMode:TEMP_TOOL_MODE_FROM_NOTE_TYPE(annotationType)];
} else {
[self addAnnotationWithType:annotationType selection:nil
point:SKUnspecifiedPoint];
This was sent by the SourceForge.net collaborative development platform, the
world's largest Open Source development site.
_______________________________________________
Skim-app-commit mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/skim-app-commit
