Revision: 16441
http://sourceforge.net/p/skim-app/code/16441
Author: hofman
Date: 2026-09-10 14:02:01 +0000 (Thu, 10 Sep 2026)
Log Message:
-----------
go back to observing NSSplitViewDidResizeSubviewsNotification instead of side
pane view frames and collapsed states. The problem appears to be local to the
user.
Modified Paths:
--------------
trunk/SKMainWindowController.m
trunk/SKMainWindowController_UI.h
trunk/SKMainWindowController_UI.m
Modified: trunk/SKMainWindowController.m
===================================================================
--- trunk/SKMainWindowController.m 2026-09-09 22:00:52 UTC (rev 16440)
+++ trunk/SKMainWindowController.m 2026-09-10 14:02:01 UTC (rev 16441)
@@ -2752,13 +2752,10 @@
if ([[change objectForKey:NSKeyValueChangeNotificationIsPriorKey]
boolValue]) {
if ([item isCollapsed] == NO && [[self window]
firstResponderIsDescendantOf:[[item viewController] view]])
[[self window] makeFirstResponder:pdfView];
- } else {
- if ([item viewController] == leftSideController)
- [toolbarController leftSidePaneDidShowOrHide:[item
isCollapsed] == NO];
- else if ([item viewController] == rightSideController)
- [toolbarController rightSidePaneDidShowOrHide:[item
isCollapsed] == NO];
- if ([[[self window] frameAutosaveName] length] && [self
interactionMode] == SKNormalMode)
- [self performSelectorOnce:@selector(sidePaneWidthDidChange)
afterDelay:0.0];
+ } else if ([item viewController] == leftSideController) {
+ [toolbarController leftSidePaneDidShowOrHide:[item isCollapsed] ==
NO];
+ } else if ([item viewController] == rightSideController) {
+ [toolbarController rightSidePaneDidShowOrHide:[item isCollapsed]
== NO];
}
} else if (context == &SKPDFAnnotationPropertiesObservationContext) {
Modified: trunk/SKMainWindowController_UI.h
===================================================================
--- trunk/SKMainWindowController_UI.h 2026-09-09 22:00:52 UTC (rev 16440)
+++ trunk/SKMainWindowController_UI.h 2026-09-10 14:02:01 UTC (rev 16441)
@@ -52,8 +52,6 @@
- (void)handlePageChangedNotification:(nullable NSNotification *)notification;
-- (void)sidePaneWidthDidChange;
-
- (NSInteger)thumbnailHighlightLevelForRow:(NSInteger)row;
- (void)updateTocSelectionHighlights;
Modified: trunk/SKMainWindowController_UI.m
===================================================================
--- trunk/SKMainWindowController_UI.m 2026-09-09 22:00:52 UTC (rev 16440)
+++ trunk/SKMainWindowController_UI.m 2026-09-10 14:02:01 UTC (rev 16441)
@@ -2108,7 +2108,7 @@
}
}
-- (void)handleSidePaneViewFrameDidChangeNotification:(NSNotification
*)notification {
+- (void)handleSplitviewDidResizeSubviewsNotification:(NSNotification
*)notification {
if ([self interactionMode] == SKNormalMode)
[self performSelectorOnce:@selector(sidePaneWidthDidChange)
afterDelay:0.0];
}
@@ -2140,12 +2140,9 @@
[nc addObserver:self
selector:@selector(handlePageLabelsChangedNotification:)
name:SKPDFPageLabelsChangedNotification
object:nil];
// NSSplitView
- if ([[[self window] frameAutosaveName] length]) {
- [nc addObserver:self
selector:@selector(handleSidePaneViewFrameDidChangeNotification:)
- name:NSViewFrameDidChangeNotification
object:leftSideController.view];
- [nc addObserver:self
selector:@selector(handleSidePaneViewFrameDidChangeNotification:)
- name:NSViewFrameDidChangeNotification
object:rightSideController.view];
- }
+ if ([[[self window] frameAutosaveName] length])
+ [nc addObserver:self
selector:@selector(handleSplitviewDidResizeSubviewsNotification:)
+ name:NSSplitViewDidResizeSubviewsNotification
object:[splitViewController splitView]];
}
@end
This was sent by the SourceForge.net collaborative development platform, the
world's largest Open Source development site.
_______________________________________________
Skim-app-commit mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/skim-app-commit
