Revision: 16510
http://sourceforge.net/p/skim-app/code/16510
Author: hofman
Date: 2026-09-20 16:09:47 +0000 (Sun, 20 Sep 2026)
Log Message:
-----------
move implementation, combine conditional code
Modified Paths:
--------------
trunk/SkimNotes/PDFAnnotation_SKNExtensions.m
Modified: trunk/SkimNotes/PDFAnnotation_SKNExtensions.m
===================================================================
--- trunk/SkimNotes/PDFAnnotation_SKNExtensions.m 2026-09-20 14:47:22 UTC
(rev 16509)
+++ trunk/SkimNotes/PDFAnnotation_SKNExtensions.m 2026-09-20 16:09:47 UTC
(rev 16510)
@@ -290,6 +290,7 @@
char SKNIsSkimNoteKey;
#if !defined(PDFKIT_PLATFORM_IOS)
+
static inline Class SKNAnnotationClassForType(NSString *type) {
#pragma clang diagnostic push
#pragma clang diagnostic ignored "-Wdeprecated-declarations"
@@ -313,6 +314,21 @@
return Nil;
#pragma clang diagnostic pop
}
+
+- (id)initSkimNoteWithBounds:(NSRect)bounds {
+#pragma clang diagnostic push
+#pragma clang diagnostic ignored "-Wdeprecated-declarations"
+ self = [self initWithBounds:bounds];
+#pragma clang diagnostic pop
+ if (self) {
+ [self setShouldPrint:YES];
+ [self setSkimNote:YES];
+ if ([self respondsToSelector:@selector(setUserName:)])
+ [self setUserName:nil];
+ }
+ return self;
+}
+
#endif
- (id)initSkimNoteWithBounds:(PDFRect)bounds forType:(NSString *)type {
@@ -377,24 +393,6 @@
return self;
}
-#if !defined(PDFKIT_PLATFORM_IOS)
-
-- (id)initSkimNoteWithBounds:(NSRect)bounds {
-#pragma clang diagnostic push
-#pragma clang diagnostic ignored "-Wdeprecated-declarations"
- self = [self initWithBounds:bounds];
-#pragma clang diagnostic pop
- if (self) {
- [self setShouldPrint:YES];
- [self setSkimNote:YES];
- if ([self respondsToSelector:@selector(setUserName:)])
- [self setUserName:nil];
- }
- return self;
-}
-
-#endif
-
- (id)initSkimNoteWithProperties:(NSDictionary *)dict{
Class stringClass = [NSString class];
NSString *type = [dict objectForKey:SKNPDFAnnotationTypeKey];
This was sent by the SourceForge.net collaborative development platform, the
world's largest Open Source development site.
_______________________________________________
Skim-app-commit mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/skim-app-commit
