Revision: 16530
http://sourceforge.net/p/skim-app/code/16530
Author: hofman
Date: 2026-09-23 14:42:31 +0000 (Wed, 23 Sep 2026)
Log Message:
-----------
local variable for user defaults
Modified Paths:
--------------
trunk/PDFAnnotationCircle_SKExtensions.m
trunk/PDFAnnotationFreeText_SKExtensions.m
trunk/PDFAnnotationInk_SKExtensions.m
trunk/PDFAnnotationLine_SKExtensions.m
trunk/PDFAnnotationSquare_SKExtensions.m
Modified: trunk/PDFAnnotationCircle_SKExtensions.m
===================================================================
--- trunk/PDFAnnotationCircle_SKExtensions.m 2026-09-23 09:05:58 UTC (rev
16529)
+++ trunk/PDFAnnotationCircle_SKExtensions.m 2026-09-23 14:42:31 UTC (rev
16530)
@@ -48,13 +48,14 @@
@implementation PDFAnnotationCircle (SKExtensions)
- (void)setDefaultSkimNoteProperties {
- NSColor *color = [[NSUserDefaults standardUserDefaults]
colorForKey:SKCircleNoteInteriorColorKey];
+ NSUserDefaults *sud = [NSUserDefaults standardUserDefaults];
+ NSColor *color = [sud colorForKey:SKCircleNoteInteriorColorKey];
if ([color alphaComponent] > 0.0)
[self setInteriorColor:color];
- [self setColor:[[NSUserDefaults standardUserDefaults]
colorForKey:SKCircleNoteColorKey]];
- [[self border] setLineWidth:[[NSUserDefaults standardUserDefaults]
floatForKey:SKCircleNoteLineWidthKey]];
- [[self border] setDashPattern:[[NSUserDefaults standardUserDefaults]
arrayForKey:SKCircleNoteDashPatternKey]];
- [[self border] setStyle:[[NSUserDefaults standardUserDefaults]
floatForKey:SKCircleNoteLineStyleKey]];
+ [self setColor:[sud colorForKey:SKCircleNoteColorKey]];
+ [[self border] setLineWidth:[sud floatForKey:SKCircleNoteLineWidthKey]];
+ [[self border] setDashPattern:[sud
arrayForKey:SKCircleNoteDashPatternKey]];
+ [[self border] setStyle:[sud floatForKey:SKCircleNoteLineStyleKey]];
}
- (NSString *)fdfString {
Modified: trunk/PDFAnnotationFreeText_SKExtensions.m
===================================================================
--- trunk/PDFAnnotationFreeText_SKExtensions.m 2026-09-23 09:05:58 UTC (rev
16529)
+++ trunk/PDFAnnotationFreeText_SKExtensions.m 2026-09-23 14:42:31 UTC (rev
16530)
@@ -60,16 +60,17 @@
}
- (void)setDefaultSkimNoteProperties {
- NSFont *font = [[NSUserDefaults standardUserDefaults]
fontForNameKey:SKFreeTextNoteFontNameKey sizeKey:SKFreeTextNoteFontSizeKey];
+ NSUserDefaults *sud = [NSUserDefaults standardUserDefaults];
+ NSFont *font = [sud fontForNameKey:SKFreeTextNoteFontNameKey
sizeKey:SKFreeTextNoteFontSizeKey];
if (font)
[self setFont:font];
- [self setColor:[[NSUserDefaults standardUserDefaults]
colorForKey:SKFreeTextNoteColorKey]];
- [self setFontColor:[[NSUserDefaults standardUserDefaults]
colorForKey:SKFreeTextNoteFontColorKey]];
- [self setAlignment:textAlignmentFromAlignment([[NSUserDefaults
standardUserDefaults] integerForKey:SKFreeTextNoteAlignmentKey])];
+ [self setColor:[sud colorForKey:SKFreeTextNoteColorKey]];
+ [self setFontColor:[sud colorForKey:SKFreeTextNoteFontColorKey]];
+ [self setAlignment:textAlignmentFromAlignment([sud
integerForKey:SKFreeTextNoteAlignmentKey])];
PDFBorder *border = [[PDFBorder alloc] init];
- [border setLineWidth:[[NSUserDefaults standardUserDefaults]
floatForKey:SKFreeTextNoteLineWidthKey]];
- [border setDashPattern:[[NSUserDefaults standardUserDefaults]
arrayForKey:SKFreeTextNoteDashPatternKey]];
- [border setStyle:[[NSUserDefaults standardUserDefaults]
floatForKey:SKFreeTextNoteLineStyleKey]];
+ [border setLineWidth:[sud floatForKey:SKFreeTextNoteLineWidthKey]];
+ [border setDashPattern:[sud arrayForKey:SKFreeTextNoteDashPatternKey]];
+ [border setStyle:[sud floatForKey:SKFreeTextNoteLineStyleKey]];
if ([border lineWidth] > 0.0) {
[self setBorder:border];
} else {
Modified: trunk/PDFAnnotationInk_SKExtensions.m
===================================================================
--- trunk/PDFAnnotationInk_SKExtensions.m 2026-09-23 09:05:58 UTC (rev
16529)
+++ trunk/PDFAnnotationInk_SKExtensions.m 2026-09-23 14:42:31 UTC (rev
16530)
@@ -63,11 +63,12 @@
}
- (void)setDefaultSkimNoteProperties {
- [self setColor:[[NSUserDefaults standardUserDefaults]
colorForKey:SKInkNoteColorKey]];
+ NSUserDefaults *sud = [NSUserDefaults standardUserDefaults];
+ [self setColor:[sud colorForKey:SKInkNoteColorKey]];
PDFBorder *border = [[PDFBorder alloc] init];
- [border setLineWidth:[[NSUserDefaults standardUserDefaults]
floatForKey:SKInkNoteLineWidthKey]];
- [border setDashPattern:[[NSUserDefaults standardUserDefaults]
arrayForKey:SKInkNoteDashPatternKey]];
- [border setStyle:[[NSUserDefaults standardUserDefaults]
floatForKey:SKInkNoteLineStyleKey]];
+ [border setLineWidth:[sud floatForKey:SKInkNoteLineWidthKey]];
+ [border setDashPattern:[sud arrayForKey:SKInkNoteDashPatternKey]];
+ [border setStyle:[sud floatForKey:SKInkNoteLineStyleKey]];
[self setBorder:[border lineWidth] > 0.0 ? border : nil];
}
Modified: trunk/PDFAnnotationLine_SKExtensions.m
===================================================================
--- trunk/PDFAnnotationLine_SKExtensions.m 2026-09-23 09:05:58 UTC (rev
16529)
+++ trunk/PDFAnnotationLine_SKExtensions.m 2026-09-23 14:42:31 UTC (rev
16530)
@@ -83,19 +83,20 @@
}
- (void)setDefaultSkimNoteProperties {
+ NSUserDefaults *sud = [NSUserDefaults standardUserDefaults];
NSRect bounds = [self bounds];
- [self setColor:[[NSUserDefaults standardUserDefaults]
colorForKey:SKLineNoteColorKey]];
- NSColor *color = [[NSUserDefaults standardUserDefaults]
colorForKey:SKLineNoteInteriorColorKey];
+ [self setColor:[sud colorForKey:SKLineNoteColorKey]];
+ NSColor *color = [sud colorForKey:SKLineNoteInteriorColorKey];
if ([color alphaComponent] > 0.0)
[self setInteriorColor:color];
- [self setStartLineStyle:[[NSUserDefaults standardUserDefaults]
integerForKey:SKLineNoteStartLineStyleKey]];
- [self setEndLineStyle:[[NSUserDefaults standardUserDefaults]
integerForKey:SKLineNoteEndLineStyleKey]];
+ [self setStartLineStyle:[sud integerForKey:SKLineNoteStartLineStyleKey]];
+ [self setEndLineStyle:[sud integerForKey:SKLineNoteEndLineStyleKey]];
[self setStartPoint:NSMakePoint(0.0, 0.0)];
[self setEndPoint:NSMakePoint(NSWidth(bounds), NSHeight(bounds))];
PDFBorder *border = [[PDFBorder alloc] init];
- [border setLineWidth:[[NSUserDefaults standardUserDefaults]
floatForKey:SKLineNoteLineWidthKey]];
- [border setDashPattern:[[NSUserDefaults standardUserDefaults]
arrayForKey:SKLineNoteDashPatternKey]];
- [border setStyle:[[NSUserDefaults standardUserDefaults]
floatForKey:SKLineNoteLineStyleKey]];
+ [border setLineWidth:[sud floatForKey:SKLineNoteLineWidthKey]];
+ [border setDashPattern:[sud arrayForKey:SKLineNoteDashPatternKey]];
+ [border setStyle:[sud floatForKey:SKLineNoteLineStyleKey]];
[self setBorder:[border lineWidth] > 0.0 ? border : nil];
}
Modified: trunk/PDFAnnotationSquare_SKExtensions.m
===================================================================
--- trunk/PDFAnnotationSquare_SKExtensions.m 2026-09-23 09:05:58 UTC (rev
16529)
+++ trunk/PDFAnnotationSquare_SKExtensions.m 2026-09-23 14:42:31 UTC (rev
16530)
@@ -48,13 +48,14 @@
@implementation PDFAnnotationSquare (SKExtensions)
- (void)setDefaultSkimNoteProperties {
- NSColor *color = [[NSUserDefaults standardUserDefaults]
colorForKey:SKSquareNoteInteriorColorKey];
+ NSUserDefaults *sud = [NSUserDefaults standardUserDefaults];
+ NSColor *color = [sud colorForKey:SKSquareNoteInteriorColorKey];
if ([color alphaComponent] > 0.0)
[self setInteriorColor:color];
- [self setColor:[[NSUserDefaults standardUserDefaults]
colorForKey:SKSquareNoteColorKey]];
- [[self border] setLineWidth:[[NSUserDefaults standardUserDefaults]
floatForKey:SKSquareNoteLineWidthKey]];
- [[self border] setDashPattern:[[NSUserDefaults standardUserDefaults]
arrayForKey:SKSquareNoteDashPatternKey]];
- [[self border] setStyle:[[NSUserDefaults standardUserDefaults]
floatForKey:SKSquareNoteLineStyleKey]];
+ [self setColor:[sud colorForKey:SKSquareNoteColorKey]];
+ [[self border] setLineWidth:[sud floatForKey:SKSquareNoteLineWidthKey]];
+ [[self border] setDashPattern:[sud
arrayForKey:SKSquareNoteDashPatternKey]];
+ [[self border] setStyle:[sud floatForKey:SKSquareNoteLineStyleKey]];
}
This was sent by the SourceForge.net collaborative development platform, the
world's largest Open Source development site.
_______________________________________________
Skim-app-commit mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/skim-app-commit
