Revision: 16594
http://sourceforge.net/p/skim-app/code/16594
Author: hofman
Date: 2026-10-03 17:14:18 +0000 (Sat, 03 Oct 2026)
Log Message:
-----------
no need to check for userName or modificationDate accessors
Modified Paths:
--------------
trunk/SkimNotes/PDFAnnotation_SKNExtensions.m
Modified: trunk/SkimNotes/PDFAnnotation_SKNExtensions.m
===================================================================
--- trunk/SkimNotes/PDFAnnotation_SKNExtensions.m 2026-10-03 16:55:58 UTC
(rev 16593)
+++ trunk/SkimNotes/PDFAnnotation_SKNExtensions.m 2026-10-03 17:14:18 UTC
(rev 16594)
@@ -421,9 +421,9 @@
[self setColor:color];
else if ([color isKindOfClass:arrayClass])
[self setColor:SKNColorFromArray((NSArray *)color)];
- if ([modificationDate isKindOfClass:dateClass] && [self
respondsToSelector:@selector(setModificationDate:)])
+ if ([modificationDate isKindOfClass:dateClass])
[self setModificationDate:modificationDate];
- if ([userName isKindOfClass:stringClass] && [self
respondsToSelector:@selector(setUserName:)])
+ if ([userName isKindOfClass:stringClass])
[self setUserName:userName];
if (lineWidth || borderStyle || dashPattern) {
if ([borderStyle respondsToSelector:@selector(integerValue)] == NO)
@@ -559,10 +559,8 @@
[dict setValue:[self type] forKey:SKNPDFAnnotationTypeKey];
[dict setValue:[self string] forKey:SKNPDFAnnotationContentsKey];
[dict setValue:[self color] forKey:SKNPDFAnnotationColorKey];
- if ([self respondsToSelector:@selector(modificationDate)])
- [dict setValue:[self modificationDate]
forKey:SKNPDFAnnotationModificationDateKey];
- if ([self respondsToSelector:@selector(userName)])
- [dict setValue:[self userName] forKey:SKNPDFAnnotationUserNameKey];
+ [dict setValue:[self modificationDate]
forKey:SKNPDFAnnotationModificationDateKey];
+ [dict setValue:[self userName] forKey:SKNPDFAnnotationUserNameKey];
[dict setValue:SKNStringFromRect([self bounds])
forKey:SKNPDFAnnotationBoundsKey];
[dict setValue:[NSNumber numberWithUnsignedInteger:pageIndex == NSNotFound
? 0 : pageIndex] forKey:SKNPDFAnnotationPageIndexKey];
if ([self border] && [[self border] lineWidth] > 0.0) {
@@ -1178,8 +1176,7 @@
if (self) {
[self setShouldPrint:YES];
[self setSkimNote:YES];
- if ([self respondsToSelector:@selector(setUserName:)])
- [self setUserName:nil];
+ [self setUserName:nil];
}
return self;
}
@@ -1518,8 +1515,7 @@
NSString *stringValue = [dict
objectForKey:SKNPDFAnnotationStringValueKey];
if ([stringValue isKindOfClass:stringClass])
[self setStringValue:stringValue];
- if ([self respondsToSelector:@selector(setModificationDate:)])
- [self setModificationDate:nil];
+ [self setModificationDate:nil];
}
return self;
}
@@ -1557,8 +1553,7 @@
NSNumber *state = [dict objectForKey:SKNPDFAnnotationStateKey];
if ([state respondsToSelector:@selector(integerValue)])
[self setState:[state integerValue]];
- if ([self respondsToSelector:@selector(setModificationDate:)])
- [self setModificationDate:nil];
+ [self setModificationDate:nil];
}
return self;
}
@@ -1597,8 +1592,7 @@
NSString *stringValue = [dict
objectForKey:SKNPDFAnnotationStringValueKey];
if ([stringValue isKindOfClass:stringClass])
[self setStringValue:stringValue];
- if ([self respondsToSelector:@selector(setModificationDate:)])
- [self setModificationDate:nil];
+ [self setModificationDate:nil];
}
return self;
}
This was sent by the SourceForge.net collaborative development platform, the
world's largest Open Source development site.
_______________________________________________
Skim-app-commit mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/skim-app-commit