Revision: 16605
http://sourceforge.net/p/skim-app/code/16605
Author: hofman
Date: 2026-10-04 15:52:39 +0000 (Sun, 04 Oct 2026)
Log Message:
-----------
revert previous commit, we still need to init before ditching PDFAnnotation,
and init is valid no matter what the documentation says
Modified Paths:
--------------
trunk/PDFAnnotation_SKExtensions.m
trunk/SkimNotes/PDFAnnotation_SKNExtensions.m
Modified: trunk/PDFAnnotation_SKExtensions.m
===================================================================
--- trunk/PDFAnnotation_SKExtensions.m 2026-10-04 15:49:31 UTC (rev 16604)
+++ trunk/PDFAnnotation_SKExtensions.m 2026-10-04 15:52:39 UTC (rev 16605)
@@ -223,7 +223,7 @@
return nil;
}
-+ (Class)annotationClassForType:(NSString *)type {
++ (Class)annotationClassForType:(NSString *)type {return self;
if ([type isEqualToString:SKNNoteString] || [type
isEqualToString:SKNTextString] || [type isEqualToString:SKNStampString])
return [SKNPDFAnnotationNote class];
else
Modified: trunk/SkimNotes/PDFAnnotation_SKNExtensions.m
===================================================================
--- trunk/SkimNotes/PDFAnnotation_SKNExtensions.m 2026-10-04 15:49:31 UTC
(rev 16604)
+++ trunk/SkimNotes/PDFAnnotation_SKNExtensions.m 2026-10-04 15:52:39 UTC
(rev 16605)
@@ -336,9 +336,7 @@
// possibly replace by a subclass
Class annotationClass = SKNAnnotationClassForType(type);
if ([self isMemberOfClass:annotationClass] == NO) {
-#if !defined(PDFKIT_PLATFORM_IOS) && (!defined(MAC_OS_X_VERSION_10_12) ||
MAC_OS_X_VERSION_MIN_REQUIRED < MAC_OS_X_VERSION_10_12)
self = [self init];
-#endif
self = [[annotationClass alloc] initSkimNoteWithBounds:bounds
forType:type];
return self;
}
@@ -396,9 +394,7 @@
annotationClass = SKNAnnotationClassForWidgetType([[dict
objectForKey:SKNPDFAnnotationWidgetTypeKey] integerValue]);
#endif
if ([self isMemberOfClass:annotationClass] == NO) {
-#if !defined(PDFKIT_PLATFORM_IOS) && (!defined(MAC_OS_X_VERSION_10_12) ||
MAC_OS_X_VERSION_MIN_REQUIRED < MAC_OS_X_VERSION_10_12)
self = [self init];
-#endif
self = [[annotationClass alloc] initSkimNoteWithProperties:dict];
return self;
}
This was sent by the SourceForge.net collaborative development platform, the
world's largest Open Source development site.
_______________________________________________
Skim-app-commit mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/skim-app-commit
