Revision: 16738
http://sourceforge.net/p/skim-app/code/16738
Author: hofman
Date: 2026-10-28 18:09:00 +0000 (Wed, 28 Oct 2026)
Log Message:
-----------
don't resolve fileURL to check for bookmark for open file
Modified Paths:
--------------
trunk/SKBookmarkController.m
Modified: trunk/SKBookmarkController.m
===================================================================
--- trunk/SKBookmarkController.m 2026-10-28 17:55:39 UTC (rev 16737)
+++ trunk/SKBookmarkController.m 2026-10-28 18:09:00 UTC (rev 16738)
@@ -634,12 +634,19 @@
return nil;
}
+static inline BOOL bookmarkHasFileURL(SKBookmark *bm, NSArray *fileURLs) {
+ for (NSURL *fileURL in fileURLs) {
+ if ([fileURL isEqual:[NSNull null]] == NO && [bm hasFileURL:fileURL])
+ return YES;
+ }
+ return NO;
+}
+
- (NSArray *)closedDocumentBookmarks {
NSArray *openFileURLs = [[[NSDocumentController sharedDocumentController]
documents] valueForKey:@"fileURL"];
NSMutableArray *closedBms = [NSMutableArray array];
for (SKBookmark *aBm in recentDocuments) {
- NSURL *fileURL = [aBm fileURL];
- if (fileURL && ([closedBms count] > 0 || [openFileURLs
containsObject:fileURL] == NO))
+ if (([closedBms count] > 0 || bookmarkHasFileURL(aBm, openFileURLs) ==
NO) && [aBm fileURL])
[closedBms addObject:aBm];
}
return closedBms;
This was sent by the SourceForge.net collaborative development platform, the
world's largest Open Source development site.
_______________________________________________
Skim-app-commit mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/skim-app-commit
