Revision: 16763
http://sourceforge.net/p/skim-app/code/16763
Author: hofman
Date: 2026-10-31 18:04:07 +0000 (Sat, 31 Oct 2026)
Log Message:
-----------
don't add properties twice
Modified Paths:
--------------
trunk/SKBookmark.m
Modified: trunk/SKBookmark.m
===================================================================
--- trunk/SKBookmark.m 2026-10-31 17:58:34 UTC (rev 16762)
+++ trunk/SKBookmark.m 2026-10-31 18:04:07 UTC (rev 16763)
@@ -505,14 +505,10 @@
- (NSDictionary *)properties {
NSMutableDictionary *properties = [NSMutableDictionary
dictionaryWithDictionary:setup];
NSData *data = [alias data];
- NSString *dataKey = [alias isBookmark] ? BOOKMARK_KEY : ALIASDATA_KEY;
- [properties removeObjectForKey:[dataKey isEqualToString:ALIASDATA_KEY] ?
BOOKMARK_KEY : ALIASDATA_KEY];
+ [properties removeObjectForKey:[alias isBookmark] ? ALIASDATA_KEY :
BOOKMARK_KEY];
[properties setObject:BOOKMARK_STRING forKey:TYPE_KEY];
- [properties setValue:data forKey:dataKey];
+ [properties setValue:data forKey:[alias isBookmark] ? BOOKMARK_KEY :
ALIASDATA_KEY];
[properties setValue:label forKey:LABEL_KEY];
- [properties addEntriesFromDictionary:[NSDictionary
dictionaryWithObjectsAndKeys:BOOKMARK_STRING, TYPE_KEY, data, dataKey, label,
LABEL_KEY, nil]];
- if (data == nil && label)
- [properties setObject:label forKey:LABEL_KEY];
if (pageIndex != NSNotFound) {
[properties setObject:[NSNumber numberWithUnsignedInteger:pageIndex]
forKey:PAGEINDEX_KEY];
if ([setup objectForKey:PAGEINDEX_KEY] && [[setup
objectForKey:PAGEINDEX_KEY] unsignedIntegerValue] != pageIndex)
This was sent by the SourceForge.net collaborative development platform, the
world's largest Open Source development site.
_______________________________________________
Skim-app-commit mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/skim-app-commit
