But the whole point /is/ to change the page /before/ doing the  
animation. Otherwise there is nothing to animate: it needs to have an  
image of both the state before and after, and only after that can  
there be an animation.

I don't think the window can draw before the animation starts, the  
redraw is only done at the end of the event loop, right? Otherwise we  
could also temporarily disable the flushWindow in  
prepareForAnimationWithTransitionStyle:..., to be sure the window  
does not flush.

Christiaan

On 17 Jul 2007, at 6:18 PM, [EMAIL PROTECTED] wrote:

> Revision: 2514
>           http://skim-app.svn.sourceforge.net/skim-app/? 
> rev=2514&view=rev
> Author:   amaxwell
> Date:     2007-07-17 09:18:33 -0700 (Tue, 17 Jul 2007)
>
> Log Message:
> -----------
> add comment
>
> Modified Paths:
> --------------
>     trunk/SKPDFView.m
>
> Modified: trunk/SKPDFView.m
> ===================================================================
> --- trunk/SKPDFView.m 2007-07-17 15:35:38 UTC (rev 2513)
> +++ trunk/SKPDFView.m 2007-07-17 16:18:33 UTC (rev 2514)
> @@ -582,6 +582,7 @@
>          transitionController = [[SKTransitionController alloc]  
> initWithView:self];
>      NSRect rect = [self convertRect:[[self currentPage]  
> boundsForBox:[self displayBox]] fromPage:[self currentPage]];
>      [transitionController prepareForAnimationWithTransitionStyle: 
> [self transitionStyle] fromRect:rect];
> +    // @@ I think going to the next/previous page before animating  
> a transition may relay on implementation details that have a very  
> high probability of breaking in future.  If goToNextPage: displays  
> the next page before the transition, things will look a bit odd...
>      if (next)
>          [super goToNextPage:self];
>      else
>
>
> This was sent by the SourceForge.net collaborative development  
> platform, the world's largest Open Source development site.
>
> ---------------------------------------------------------------------- 
> ---
> This SF.net email is sponsored by DB2 Express
> Download DB2 Express C - the FREE version of DB2 express and take
> control of your XML. No limits. Just data. Click to get it now.
> http://sourceforge.net/powerbar/db2/
> _______________________________________________
> Skim-app-commit mailing list
> [EMAIL PROTECTED]
> https://lists.sourceforge.net/lists/listinfo/skim-app-commit


-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
_______________________________________________
skim-app-develop mailing list
skim-app-develop@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/skim-app-develop

Reply via email to