On Tue, 13 Aug 2019 15:18:59 -0400 "Andrew Payne" <phala...@komputermatrix.com> wrote:
> I'm seeing that when I update slackbuilds I maintain, files other than > *.SlackBuild, *.info and slack-desc are not changed on the SBo > website. > > My question then is, should I do PRs for changes to other files > (e.g., the README), or make a note in the submission form that > changes to other files have been made? Hmmm, do you know who committed the update(s) in question? I recall doing a few in which the README change(s) looked either inconsequential (i.e. probably accidental, e.g. added whitespace at the end of a line) or they were more confusing than the copy that was already in the git repo, so I overwrite the new copy with our current one. I have no idea which specific builds those were or who maintained them though. I don't know everyone else's workflow, but for me, there's no way to accidentally miss changes to the README - once I make whatever fixups I need to make to a submission, I move the entire $app directory over to the git repo in place of the old $app dir, and then a combination of "git status" and "git diff" are used to make sure I didn't miss e.g. a new patch and review the changes to everything against the current version in the repo. -RW
pgptwOeV0yj2B.pgp
Description: OpenPGP digital signature
_______________________________________________ SlackBuilds-users mailing list SlackBuilds-users@slackbuilds.org https://lists.slackbuilds.org/mailman/listinfo/slackbuilds-users Archives - https://lists.slackbuilds.org/pipermail/slackbuilds-users/ FAQ - https://slackbuilds.org/faq/
