Hello everyone

we have just noticed a few things after observing this week's public update
(the issue has persisted for a long time ago, but we never noticed it) that
some scripts, despite passed the CI test, resulted in some broken symlinks or
owners

We urge maintainers to review their own scripts for following things:
1. If you want to copy certain file from your SlackBuild directory ($CWD),
please use cat instead of cp. Please see this example:
https://git.slackbuilds.org/slackbuilds/commit/?id=2f3b425e3

2. Please review the final doinst.sh.
Some scripts has a symlink outside of the resulting package, most likely it
linked to the build directory. So far, pghvlaans reported lammps and
fonts-redhat (fixed). There might be others.
this is an example of lammps (which is incorrect)
 ( cd usr/share/lammps/potentials ; ln -sf /var/cache/sbopkg/C_10_10.mesocnt
C_10_10.mesocnt )
this is an example of fonts-redhat which has been fixed
( cd etc/fonts/conf.d ; rm -rf 60-overpass-fonts.conf )
( cd etc/fonts/conf.d ; ln -sf ../conf.avail/60-overpass-fonts.conf
60-overpass-fonts.conf )

If you think you found some scripts failing with these same issue which is not
your own scripts, please raise and issue in github/gitlab and please provide
some evidence (doinst.sh is good example)

Thank you

--
Willy Sudiarto Raharjo

Attachment: pgpG9M175ISJJ.pgp
Description: OpenPGP digital signature

_______________________________________________
SlackBuilds-users mailing list
[email protected]
https://lists.slackbuilds.org/mailman/listinfo/slackbuilds-users
Archives - https://lists.slackbuilds.org/pipermail/slackbuilds-users/
FAQ - https://slackbuilds.org/faq/

Reply via email to