DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT <http://nagoya.apache.org/bugzilla/show_bug.cgi?id=5582>. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE.
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=5582 JDBCContentStore.retrieveRevisionContent - not closing connections Summary: JDBCContentStore.retrieveRevisionContent - not closing connections Product: Slide Version: Nightly Platform: Other OS/Version: Other Status: NEW Severity: Normal Priority: Other Component: Stores AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] Hi, I am using an Oracle backed JDBCContentStore with slide 1.0.16. Everytime we download a document - eg through the webapp. A new cursor is being opened - but this never seems to be being released. We found this out because we hit the "ORA-01000 maximum open cursors exceeded" error from oracle. I am guessing that the above class/method is the likely candidate - as it seems to be the method that gets the content. It also does not seem to release the prepared statement it creates. Looking at it, I presume we cannot just close it in the method - as the input stream for the binary object won't have been read at that point. So - should it read the whole object in and then close the connection here? Or should some finaliser code in the NodeRevisionContent object close the connection? Although this option does not sound right... Or perhaps wrap the InputStream so that when it is closed, the underlying JDBC statement is closed too. Comments - I will probably go for the last option in my code. I will submit the patch here. Regards, Chris -- To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]> For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>
