> Remy Maucherat wrote: > > > > > Add the database test statements and calls to > > > connectIfNeededAndPossible() > > > to the J2EEContentStore as well - now the store will reconnect to the > > > database if the connection stops working (if, for example, the socket > > > times out or is otherwise invalidated). > > > > I don't think that's a good idea. I would think the connection handling is > > the responsability of the connection pool. > > I would think so too, but because of the way the J2EE stores are > structured, this was the appropriate way to make it work - it'd probably > be worth rewriting the stores more extensively at some point, but I > don't really know the J2EE stuff well enough to do this at the moment. > (the patch you were responding about is basically the same as one I > committed to the J2EEDescriptorsStore - I forgot about the content store > since I don't use it). > > If you want to revert my patch, I don't mind - but _something_ is needed > to make this work right.
That's fine for now. Actually, the usage the store makes of the pool is not correct at the moment, so a partial rewrite will be indeed needed. BTW, sorry for the lack of responsiveness these days. I've been travelling lately (and I don't handle jet lag very well :-(), and spending lots of time on Tomcat. Remy -- To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]> For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>
