On 10 Jan 2003 at 15:55, Christopher Lenz wrote: > > FYI, it is not recommended practice to checkin JARs to CVS, at > least it has not been for this subproject. Exceptions are for > example jdom-dev.jar or a snapshot of commons-httpclient, which > hasn't seen a release for ages.
Aha, I see. > > Commons-Logging OTOH has had a couple of stable releases by now, > without API changes, and I see no good reason to put it in CVS. What does OTOH mean? And by the way: IMHO? > > > I think the build.xml has to be changed too. > > It is the only thing that should change. Patch? ;-) I attached two patches for build.xml and build.properties.sample. It's the 1st time I created a patch, so please be kind. I hope I haven't missed a place for change... I created these by the following commands: cvs -d :pserver:[EMAIL PROTECTED]:/home/cvspublic checkout jakarta-slide/build.xml > change and test file cvs -d :pserver:[EMAIL PROTECTED]:/home/cvspublic -z3 diff - R -Nu jakarta-slide/build.xml > build.patch and cvs -d :pserver:[EMAIL PROTECTED]:/home/cvspublic checkout jakarta-slide/build.properties.sample > change file cvs -d :pserver:[EMAIL PROTECTED]:/home/cvspublic -z3 diff - R -Nu jakarta-slide/build.properties.sample> build.properties.sample.patch > > -chris > Andreas
The following section of this message contains a file attachment
prepared for transmission using the Internet MIME message format.
If you are using Pegasus Mail, or any another MIME-compliant system,
you should be able to save it or view it from within your mailer.
If you cannot, please ask your system administrator for assistance.
---- File information -----------
File: build.patch
Date: 10 Jan 2003, 21:27
Size: 4809 bytes.
Type: Unknown
build.patch
Description: Binary data
Index: jakarta-slide/build.properties.sample
===================================================================
RCS file: /home/cvspublic/jakarta-slide/build.properties.sample,v
retrieving revision 1.17
diff -u -r1.17 build.properties.sample
--- jakarta-slide/build.properties.sample 22 Dec 2002 09:06:54 -0000 1.17
+++ jakarta-slide/build.properties.sample 10 Jan 2003 20:34:03 -0000
@@ -118,6 +118,11 @@
#commons-modeler.lib=${commons-modeler.home}
#commons-modeler.jar=${commons-modeler.lib}/commons-modeler.jar
+# ----- Commons Logging -----
+#commons-logging.home=${cvs.home}/commons-logging
+commons-logging.lib=${base.path}/lib
+#commons-logging.lib=${commons-logging.home}
+#commons-logging.jar=${commons-logging.lib}/commons-logging.jar
# ----- Commons Pool, version 20011030 or later -----
#commons-pool.home=${cvs.home}/commons-pool
-- To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]> For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>
