Hi Eric, be sure I am considering your patch. In fact I have added a lot more to it, especially to the JavaDoc comments. But I have some difficulties applying it now just because I want to take the opportunity to replace the HttpURL stuff from Slide with the one from Commons-Httpclient. There are some minor issues, I still have to think about. But I can't spend the whole day with it. So please be a bit patient. I hope I can resubmit the revised patch for your review and anyone else to try it out the next week.
Regards, Ingo > Tony, > > It would seem you were too quick for me to respond to you on the Slide > mailing list. > > Tony Bigbee wrote: > > > Eric, > > > > Thanks for your response. I checked the beta 1 code and it appears > > that the core approach to reading a char/byte at a time from the > > InputStream is still there. > > It looks like there have been tons of structural changes, so perhaps > > things will be better. I had been wondering why BufferedInputStreams > > weren't being used to improve > > performance (assuming that the cpu consumption I discovered would be > > improved by buffering). Perhaps there are important design > > considerations that mandate > > InputStreams from the Commons point of view. But I should probably > > post these questions to the Commons Httpclient list. > > There are all sorts of tricks being used to wrap the InputStreams from > the server. I believe they are buffered, although you'd be hard pressed > to "get at" the buffering stream, since I believe it is done at a low > level inside of HttpClient. > > > > > So you're able to use the latest webdavclient lib from CVS with > > HttpClient beta1/2 with no modifications? Or are the modifications to > > get these to work together in your submitted patch? > > See my email from 6/25/2003, here in the archives at: > > http://archives.apache.org/eyebrowse/[EMAIL PROTECTED]&msgNo=7222 > > It is perfectly possible to use the current CVS webdav client with the > latest HttpClient. There were some legacy limitations that my patch > addresses. If you grab the latest code for both, it should be roughly > compatible with your existing code. Once you've fixed up your code to > match the latest, I think you'll find the API cleaner, the compatibility > excellent, and the performance radically improved. > > You can apply my patch if any of the issues addressed in the patch > concern you. In fact, if you do apply the patch and it works for you, > I'm sure that positive feedback to that effect would probably encourage > the committers on the list, who may not have the time to test patches > themselves, but need some recognition that the patch works before > committing it. > > > > > I'm confused about Webdavresource.java having an import of: > > > > import org.apache.util.HttpURL; > > > > and the presence of a > > org.apache.commons.httpclient.HttpURL in the beta 1 distribution. > > There is legacy code in both projects, since HttpClient sprang into > existence from the Slide project originally. There are other > similarities I'm sure you'd find if you looked. > > Of course it would be great if the similar or redundant code could be > revised and merged as appropriate. Of course, since the two projects in > question are both open source, the opportunity lies with whomever will > tackle the problem. I've not had time. Perhaps you do? > > -Eric. --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
