Hi All

Resubmitting the latest J2EEStore related classes from our CVS. I have
incorporated the point(1) raised by Oliver. Now we have nested
try..final blocks for each.

Include the SQLServer Schema with and with out foreign key relations and
the sample domain.xml

Ashok

-----Original Message-----
From: Britton, Colin 
Sent: Tuesday, November 04, 2003 9:13 AM
To: [EMAIL PROTECTED]
Subject: RE: REQUEST FOR HELP/COMMENT: Store problems

>1.) There is this closing of resources issue:
>If you take a closes look you will see statement will not be closed
when 
>res.close() rises an exception. Admittedly, this is unlikely, but why 
>risking this? Maybe it is fixed in your code, already? I know it is 
>ugly, but maybe like this:

Agreed that it should be fixed.

>2.) Why do you think the approach in org.apache.slide.store.impl.rdbms 
>is better than yours? Why is there an adapter? Also, where do you see a

>nicer Java approach?

Well with the adaptor then different DB optimizations maybe more easily
accommodated.
Also I prefer more structure that one big store class. What we have
today grew out of something smaller.


>3.) I do not think org.apache.slide.store.impl.rdbms.J2EEStore does an 
>auto-commit, but the other way round. It sets auto-commit to false. 
>Although, it seems doing this causes trouble as indicated in

OK. Clearly I am not paying enough attention!

Ashok will re-post our latest version, I don't think we have changed
much.

Rgds
CB


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Attachment: slidestore.zip
Description: slidestore.zip

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to