Re: [client-patch] Error requesting child resources

[Mike Oliver]

Although not a commiter, I would vote +1

Ollie

Martin Dulisch wrote:

+ 1 from me, 

 

-----Original Message-----
From: Ingo Brunberg [mailto:[EMAIL PROTECTED] 
Sent: Montag, 12. Januar 2004 15:40
To: [EMAIL PROTECTED]
Subject: Re: [client-patch] Error requesting child resources

OK, I think we should switch ASAP. I have been hesitating simply
because of the required API changes. What I'm unsure about is wether I
should try to deprecate as much old stuff as possible. If nobody
insists on that, I should be able to migrate really fast.
As I believe we need a formal vote on this, I propose to switch from
using org.apache.util.HttpURL to org.apache.commons.httpclient.HttpURL
in the client library. This would affect certain constructors and the
setHttpURL and getHttpURL methods in WebdavResource. This switch is
neccessary to make the client lib a true extension of Commons
Httpclient and to circumvent some current URI escaping bugs.
+1 from me.

Ingo

   

From: Ingo Brunberg [mailto:[EMAIL PROTECTED] 
Sent: Montag, 12. Januar 2004 13:08

Hi Martin,

this is a known problem, that was discussed not too long before.
The href that a WebDAV server returns has to be escaped 
       

according to
   

the specs, so there's nothing wrong with that.
The real problem is the HttpURL class that is part of 
       

Slide. It has
   

some "broken" constructors that do not correctly escape the given
path. I you want to be sure, use the constructor that 
       

takes a ready to
   

use escaped URL.

       

Thanks Ingo, this is a bad trap in util.HttpUrl. Now I use 
     

the class from
   

commons in my client and it works.

     

I didn't want to fix it because I'd rather switch to 
       

using the HttpURL
   

class from Commons Httpclient, which I think is "bug free". The
problem is that this requires an API change, but it has to be done
anyway, because Slide client is effectively a companion to Commons
Httpclient.
       

Have you started to migrate yet. If not I could contibute 
     

to this. Currently
   

im am developing a WebDAV client and could test the 
     

changes. What about
   

switching form util.HttpURL to commons in a first step? I 
     

think it is a good
   

time to change API before the release is out.

+1 for using as much as possible from Commons HttpClient.

Martin
     

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
   



---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
 



---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]