The proposal for events has been there for a while now, Daniel explained what he changed in the core classes, his code compiles and seems to work and I did not see any vetos.
I will check it in into the HEAD now. I will set tags before and after the checkin:
Before: SLIDE_HEAD_BEFORE_EVENTS After: SLIDE_HEAD_AFTER_EVENTS
If there are vetos after checkin I will undo the changes ASAP.
Cheers,
Oliver
Daniel Florey wrote:
Hi,
I want to give you a short list of the changes in the core classes, so that we can run the vote on the event stuff that I've sent to the list.
First of all the events don't affect the behaviour of slide if they are turned off. Everything should be backward compatible.
- added a new package in share: org.apache.slide.event that contains all basic event classes and interfaces.
- added a new package in webdav: org.apache.slide.webdav.event that contains the webdav related event and listener
- modified almost every helper and helperImpl (e.g. Content and ContentHelper) to fire the events.
- Introduced VetoException that can be thrown if an event listener want to reject the method from which it was called. This VetoException is handled as other SlideExceptions and is finally mapped to the error code NotAcceptable if a webdav request is vetoed.
- Introduced the Interface to org.apache.slide.util.conf.Configurable that can be used to mark classes that can be configured via Domain.xml. This can at the moment be used to build configurable event listeners. So event listeners can be configured in a more sophisticated way then interceptors.
This patch will for sure not make it into 2.0 release branch, so I hope for your votes to give it a try :-)
Daniel
--------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
.
--------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
