ahh beautiful :-) +1
Jacob ----- Original Message ----- From: "Oliver Zeigermann" <[EMAIL PROTECTED]> To: "Slide Developers Mailing List" <[EMAIL PROTECTED]> Sent: Friday, July 16, 2004 11:02 AM Subject: Re: PLEASE REVIEW / WAS cvs commit: jakarta-slide/src/webdav/server/org/apache/slide/webdav/util VersioningHelper.java > Nono, quite different. Only talking about VHRs you find in the /history > folder. Your folder will look like > > 1 > 2 > 3 > > but mine looks like > > Important.doc > Proposal.doc > Einkaufsliste.doc > > The versioned resources are *inside* these collections and are not > effected at all. > > Oliver > > Jacob Lund wrote: > > > I am not sure if I understand this correctly. > > > > If I change the displayname of a resource and then do a checkin then the > > value of displayname will be overwritten with the name of the resource? If > > so then displayname should be a protected property since displayname no > > longer will be versionable. > > > > If this is the case then this feature should be a setting in the domain.xml. > > > > /jacob > > > > ----- Original Message ----- > > From: "Oliver Zeigermann" <[EMAIL PROTECTED]> > > To: "Slide Developers Mailing List" <[EMAIL PROTECTED]> > > Sent: Thursday, July 15, 2004 3:53 PM > > Subject: PLEASE REVIEW / WAS cvs commit: > > jakarta-slide/src/webdav/server/org/apache/slide/webdav/util > > VersioningHelper.java > > > > > > > >>Please have a look at this very simple patch. I have set the display > >>name of the VHR to the displayname of the resource that gets versioned. > >>This makes it easier to find the versions of the resource in the history > >>folder with non-DeltaV-aware clients like the Windows Explorer as they > >>are no longer called '4711', but rahter 'Important.doc'. Please note > >>that this does not effect the path of the VHR, but only the displayname. > >> > >>What do you folks say? Should we keep it this way or shall I undo my > > > > change? > > > >>Oliver > >> > >>[EMAIL PROTECTED] wrote: > >> > >> > >>>ozeigermann 2004/07/15 06:46:21 > >>> > >>> Modified: src/webdav/server/org/apache/slide/webdav/util > >>> VersioningHelper.java > >>> Log: > >>> Set the display name of the VHR to the name of the resource that gets > >>> versioned to make it a easier to find versions with clients > >>> that do not support DeltaV (like MS Explorer). > >>> > >>> Revision Changes Path > >>> 1.104 +5 -4 > > > > jakarta-slide/src/webdav/server/org/apache/slide/webdav/util/VersioningHelpe > > r.java > > > >>> Index: VersioningHelper.java > >>> =================================================================== > >>> RCS file: > > > > /home/cvs/jakarta-slide/src/webdav/server/org/apache/slide/webdav/util/Versi > > oningHelper.java,v > > > >>> retrieving revision 1.103 > >>> retrieving revision 1.104 > >>> diff -u -r1.103 -r1.104 > >>> --- VersioningHelper.java 24 Jun 2004 13:18:52 -0000 1.103 > >>> +++ VersioningHelper.java 15 Jul 2004 13:46:21 -0000 1.104 > >>> @@ -328,7 +328,8 @@ > >>> vhrNrd.setLastModified( new Date() ); // P_GETLASTMODIFIED > >>> vhrNrd.setContentLength( 0 ); // P_GETCONTENTLENGTH > >>> vhrNrd.setETag( PropertyHelper.computeEtag(vhrUri, vhrNrd) ); > > > > // P_GETETAG > > > >>> - vhrNrd.setName( vhrUh.getHistoryName() ); // P_DISPLAYNAME > >>> +// vhrNrd.setName( vhrUh.getHistoryName() ); // P_DISPLAYNAME > >>> + vhrNrd.setName( rNrd.getName() ); // P_DISPLAYNAME > >>> vhrNrd.setProperty( > >>> new NodeProperty(P_VERSION_SET, > > > > pHelp.createHrefValue(vrUri)) ); > > > >>> vrNrd.setCreationDate( new Date() ); // P_CREATIONDATE > >>> > >>> > >>> > >>> > >>>--------------------------------------------------------------------- > >>>To unsubscribe, e-mail: [EMAIL PROTECTED] > >>>For additional commands, e-mail: [EMAIL PROTECTED] > >>> > >> > >> > >>--------------------------------------------------------------------- > >>To unsubscribe, e-mail: [EMAIL PROTECTED] > >>For additional commands, e-mail: [EMAIL PROTECTED] > >> > > > > > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: [EMAIL PROTECTED] > > For additional commands, e-mail: [EMAIL PROTECTED] > > > > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [EMAIL PROTECTED] > For additional commands, e-mail: [EMAIL PROTECTED] > --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
