On Thu, 2005-02-10 at 17:55 +0100, Oliver Zeigermann wrote:
> On Wed, 09 Feb 2005 23:32:23 -0800, James Mason <[EMAIL PROTECTED]> wrote:
> > Both look useful, although I'm not sure I understand how #1 actually
> > works. It's late, so my brain's not working right, but could you explain
> > it a little? :)
> 
> Yes, my explanations wasn't very good: In WebdavUtils there is this
> method getRelativePath which translates the request to the path used
> for the request. The hook in (1) allows you to supply a custom
> mapping.

Ok. That's pretty cool. Nice feature :).

> 
> > Also, a couple suggestions. Can you add a log message when you catch all
> > Exceptions thrown when creating the PathMapper? That makes it easier to
> > tell what went wrong when the error occurs :). And, the authentication
> 
> Right, I just did not seem to remember how to get access to any logger
> at that position - but remembered and added it now.

I wonder if it would be a good idea to migrate to commons-logging? It's
extremely easy to use, and I *think* just changing the Domain.log()
implementation would be enough to maintain backward compatibility.
Thoughts?

> 
> > header returned from #2 should probably be configurable since most app
> > servers support more than just Basic authentication. That could lead to
> > issues later.
> 
> Right and the WebDAV realm name should be configurable as well. Will
> do so ASAP. Should this be configured in Domain.xml?

Domain.xml seems like the right place to me. It's easier to edit than
the .properties file anyway :).

-James

> 
> Oliver
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]
> 
> 


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to