Should be fixed now.

Oliver

On 6/2/05, Max Pfingsthorn <[EMAIL PROTECTED]> wrote:
> Dear Devs,
> 
> I found this in the ByteSizeLimitedObjectCache:
> 
> public synchronized boolean canCache(Object txId, long byteSize) {
>         long maxSize;
>         if (txId != null) {
>             maxSize = globalByteSize;
>         } else {
>             maxSize = txByteSize;
>         }
>         return (maxSize >= byteSize && maxByteSizePerEntry >= byteSize);
>     }
> 
> Shouldn't this be
> 
> public synchronized boolean canCache(Object txId, long byteSize) {
>         long maxSize;
>         if (txId != null) {
>             maxSize = txByteSize;
>         } else {
>             maxSize = globalByteSize;
>         }
>         return (maxSize >= byteSize && maxByteSizePerEntry >= byteSize);
>     }
> 
> since the semantics are that the local transactional cache is used when txId 
> is not null...
> 
> Can someone with commit karma fix it?
> 
> Best regards,
> 
> Max Pfingsthorn
> 
> Hippo
> 
> Oosteinde 11
> 1017WT Amsterdam
> The Netherlands
> Tel  +31 (0)20 5224466
> -------------------------------------------------------------
> [EMAIL PROTECTED] / www.hippo.nl
> --------------------------------------------------------------
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]
> 
>

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to