Sounds like a good idea to me. What about configuring the table names in Domain.xml?

Also having the old table names as default would be good for backward compatibility.

Oliver

Var George schrieb:

When I try to create slide tables on my existing application schema, I have some name 
conflicts because slide tables are named without any namespace prefix (e.g. 
PERMISSIONS vs SLIDE_PERMISSIONS). I would like to make slide table names configurable 
to solve this problem.



Here are the changes that I am considering



1. AbstratRDBMSAdapter.java:

---------------------------------------

Define constants for all table names and statically initialize them from a property file 
(slide.properties ?). if property files doesn’t exist or property is not configured 
then initialize them to use default names (this way these changes will be backward compatible)



e.g.

protected final String URI_TABLE = resolveRDBMSObjectName(“URI”);;





2. StandardRDBMSAdapter.java

--------------------------------------------

Update this class to use the constants instead of hard coded table names



e.g.

connection.prepareStatement("select 1 from " + OBJECT_TABLE + " o, " + URI_TABLE + " u " + 
where o.URI_ID=u.URI_ID and u.URI_STRING=?");



3. CommonRDBMSAdapter.java

----------------------------------------

Update this class to use the constants instead of hard coded table names, similar to 
(2)



4. RDBMSComparableResourcesPool.java

---------------------------------------------------------

Update this class to use the constants instead of hard coded table names, similar to 
(2)



I am using CommonRDBMSAdapter against Oracle 9i so I am not sure how many of the 
platform specific **RDBMSAdapter classes are required but the strategy will be to 
apply changes to all required classes similar to (2)



Please let know you your thoughts on this approach. Also I would like to know if slide 
team is interested to pull these changes into slide as a standard enhancement. I will 
be glad to send my changes if you are interested.



 regards

Var George


--------------------------------- Do you Yahoo!? Read only the mail you want - Yahoo! Mail SpamGuard.


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Reply via email to