Great, thanks Andy! I will let you know when it is time :)
Oliver On Sat, 27 Nov 2004 20:25:34 -0500, Andrew Miller <[EMAIL PROTECTED]> wrote: > That's fine with me. I'll keep it in my local tree and continue to > build with it. When it comes time to intergrate, let me know if you > have any questions about the code. > > --Andy > > On Thu, 25 Nov 2004 12:16:52 +0100, Oliver Zeigermann > > > <[EMAIL PROTECTED]> wrote: > > After I had a closer look at this it seems your patch seems to fit > > nicely into the PathForIDMapper proposed by Antraning in > > > > http://nagoya.apache.org/eyebrowse/ReadMsg?listId=105&msgNo=7373 > > > > Let's wait until the infrastructure for this is set up and take over > > your code then. > > > > Oliver > > > > > > > > On Thu, 25 Nov 2004 11:32:40 +0100, Oliver Zeigermann > > <[EMAIL PROTECTED]> wrote: > > > Thanks for the patch, I really like it and would like to see it in 2.1 > > > final. The idea to limit path size to 128 is a nice idea, but you know > > > there is the risk of two different paths to be encooded to the same > > > MD5 hash. Although this is rather unlikely... > > > > > > As the file system has moved to > > > > > > http://jakarta.apache.org/commons/transaction/ > > > > > > which has its own release cycle your patch won't make it to Slide 2.1 > > > rc1, but only to the final version. > > > > > > Oliver > > > > > > > > > > > > > > > On Wed, 24 Nov 2004 12:02:22 -0500, Andrew Miller <[EMAIL PROTECTED]> > > > wrote: > > > > A few months ago I added a new paramater that indicates that portable > > > > paths should be used. We were having problems storing Japanese file > > > > names on Windows and then migrating the store to Linux. > > > > > > > > It uses a technique similar to url-encode-path (base64 encode, then > > > > url encode), but it only encodes non-latin paths and encodes each path > > > > segment to avoid all files being contained in a single directory. It > > > > also limits file length for files stored to the filesytem to 128 > > > > characters, using an MD5 hash of the filename to ensure uniqueness > > > > when truncating. > > > > > > > > I have always meant to contribute this code and it sounds like now may > > > > be the time. I have my changes against the SLIDE_2_1_M1_RELEASE tag. > > > > I attached the patches for the 2 modified files. I'm happy to create > > > > a bug report and if that is preferred. > > > > > > > > --Andy > > > > > > > > > > > > > > > > > > > > On Wed, 24 Nov 2004 09:52:44 +0100, Jacob Lund <[EMAIL PROTECTED]> > > > > wrote: > > > > > The url-encode-path was originally added to enable you to save files > > > > > using > > > > > characters not available in your operating system. I did some testing > > > > > with > > > > > russian filenames and it only worked when this parameter was set to > > > > > true. > > > > > > > > > > /jacob > > > > > > > > > > > > > > > > > --------------------------------------------------------------------- > > > > > > > > > > To unsubscribe, e-mail: [EMAIL PROTECTED] > > > > For additional commands, e-mail: [EMAIL PROTECTED] > > > > > > > > > > > > > > > > > > > --------------------------------------------------------------------- > > > To unsubscribe, e-mail: [EMAIL PROTECTED] > For additional commands, e-mail: [EMAIL PROTECTED] > > --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
