Hmmm, I guess you are right. At least when you use versioning. And if
you do not the hack has no effect. So, I would be +1 for having it as
default. However, this should be done for 2.2 and not for 2.1 in order
not to introduce incompatibilities.
Oliver
On Thu, 9 Dec 2004 16:22:14 +0100, Jacob Lund <[EMAIL PROTECTED]> wrote:
> I know but it makes the slide project useable! This feature should be
> enabled by default since slide basically kills itself without it!
>
>
>
> /jacob
>
> ----- Original Message -----
> From: "Oliver Zeigermann" <[EMAIL PROTECTED]>
> To: "Slide Users Mailing List" <[EMAIL PROTECTED]>
> Sent: Thursday, December 09, 2004 4:11 PM
> Subject: Re: history-collection-hack bug
>
> > After all it is just a hack...
> >
> > Oliver
> >
> >
> > On Thu, 9 Dec 2004 16:08:44 +0100, Jacob Lund <[EMAIL PROTECTED]> wrote:
> >> Hi!
> >>
> >> I have been looking more into this and it seems that Oliver's conclusion
> >> was
> >> right. In order to get the correct history path you need to know what uri
> >> the request originates from, and from what I can see, this information is
> >> not available as the system is constructed now.
> >>
> >> I still think that this should be fixed in later versions of slide, but
> >> for
> >> now I guess we have to state that these two settings are not compatible.
> >>
> >>
> >>
> >> /jacob
> >>
> >> ----- Original Message -----
> >> From: "Jacob Lund" <[EMAIL PROTECTED]>
> >> To: "Slide Users Mailing List" <[EMAIL PROTECTED]>;
> >> <[EMAIL PROTECTED]>
> >> Sent: Wednesday, December 08, 2004 3:59 PM
> >> Subject: Re: history-collection-hack bug
> >>
> >> > Well from what I can see, there should be no problem with the
> >> > combination!
> >> > The only thing is this getHistoryPathHandler function! However to
> >> > resolve
> >> > the history path I need some information that is not available in the
> >> > class by default, but as I said I am not very familiar with this part
> >> > of
> >> > the code.
> >> >
> >> > /jacob
> >> >
> >> > ----- Original Message -----
> >> > From: "Oliver Zeigermann" <[EMAIL PROTECTED]>
> >> > To: "Slide Users Mailing List" <[EMAIL PROTECTED]>
> >> > Sent: Wednesday, December 08, 2004 3:47 PM
> >> > Subject: Re: history-collection-hack bug
> >> >
> >> >
> >> >> ???
> >> >>
> >> >> Maybe the problem is that the history folder structures with the hack
> >> >> turned on / off are incompatible?
> >> >>
> >> >> Oliver
> >> >>
> >> >>
> >> >> On Wed, 8 Dec 2004 15:41:02 +0100, Jacob Lund <[EMAIL PROTECTED]>
> >> >> wrote:
> >> >>> OK - I think I found the origin of the problem.
> >> >>>
> >> >>> In the HistoryPathHandler class there are 2 getHistoryPathHandler
> >> >>> functions,
> >> >>> but only one of them are handling the situation where the history
> >> >>> path
> >> >>> has a
> >> >>> parameter in it.
> >> >>>
> >> >>> I don't know this part of the code very well, so I don't have a
> >> >>> solution
> >> >>> yet.
> >> >>>
> >> >>> /jacob
> >> >>>
> >> >>>
> >> >>>
> >> >>>
> >> >>> ----- Original Message -----
> >> >>> From: "Jacob Lund" <[EMAIL PROTECTED]>
> >> >>> To: "Slide Users Mailing List" <[EMAIL PROTECTED]>;
> >> >>> <[EMAIL PROTECTED]>
> >> >>> Sent: Tuesday, December 07, 2004 3:42 PM
> >> >>> Subject: Re: history-collection-hack bug
> >> >>>
> >> >>> >I am looking into it now - i just found out!
> >> >>> >
> >> >>> > It does not throw an exception! I will report back as soon as I
> >> >>> > have
> >> >>> > something.
> >> >>> >
> >> >>> > /jacob
> >> >>> >
> >> >>> > ----- Original Message -----
> >> >>> > From: "Oliver Zeigermann" <[EMAIL PROTECTED]>
> >> >>> > To: "Slide Users Mailing List" <[EMAIL PROTECTED]>
> >> >>> > Sent: Tuesday, December 07, 2004 3:35 PM
> >> >>> > Subject: Re: history-collection-hack bug
> >> >>> >
> >> >>> >
> >> >>> >> Any idea what the problem with the hack is?
> >> >>> >>
> >> >>> >> Oliver
> >> >>> >>
> >> >>> >>
> >> >>> >> On Tue, 7 Dec 2004 12:33:16 +0100, Jacob Lund <[EMAIL PROTECTED]>
> >> >>> >> wrote:
> >> >>> >>> Hi all,
> >> >>> >>>
> >> >>> >>> When slide is configured to split the history collection into
> >> >>> >>> seperate
> >> >>> >>> stores <parameter
> >> >>> >>> name="historypath">/history/${store}</parameter>,
> >> >>> >>> then
> >> >>> >>> the history-collection-hack breaks the versioning part of slide.
> >> >>> >>>
> >> >>> >>> I have attached an example domain.xml file. When
> >> >>> >>> history-collection-hack
> >> >>> >>> is
> >> >>> >>> set to false it works fine.
> >> >>> >>>
> >> >>> >>> I tested this with 2.1rc1.
> >> >>> >>>
> >> >>> >>> /jacob
> >> >>> >>>
> >> >>> >>>
> >> >>> >>> ---------------------------------------------------------------------
> >> >>> >>> To unsubscribe, e-mail: [EMAIL PROTECTED]
> >> >>> >>> For additional commands, e-mail:
> >> >>> >>> [EMAIL PROTECTED]
> >> >>> >>>
> >> >>> >>>
> >> >>> >>>
> >> >>> >>
> >> >>> >> ---------------------------------------------------------------------
> >> >>> >> To unsubscribe, e-mail: [EMAIL PROTECTED]
> >> >>> >> For additional commands, e-mail:
> >> >>> >> [EMAIL PROTECTED]
> >> >>> >>
> >> >>> >
> >> >>> >
> >> >>> > ---------------------------------------------------------------------
> >> >>> > To unsubscribe, e-mail: [EMAIL PROTECTED]
> >> >>> > For additional commands, e-mail: [EMAIL PROTECTED]
> >> >>> >
> >> >>>
> >> >>> ---------------------------------------------------------------------
> >> >>> To unsubscribe, e-mail: [EMAIL PROTECTED]
> >> >>> For additional commands, e-mail: [EMAIL PROTECTED]
> >> >>>
> >> >>>
> >> >>
> >> >> ---------------------------------------------------------------------
> >> >> To unsubscribe, e-mail: [EMAIL PROTECTED]
> >> >> For additional commands, e-mail: [EMAIL PROTECTED]
> >> >>
> >> >
> >> >
> >> > ---------------------------------------------------------------------
> >> > To unsubscribe, e-mail: [EMAIL PROTECTED]
> >> > For additional commands, e-mail: [EMAIL PROTECTED]
> >> >
> >>
> >> ---------------------------------------------------------------------
> >> To unsubscribe, e-mail: [EMAIL PROTECTED]
> >> For additional commands, e-mail: [EMAIL PROTECTED]
> >>
> >>
> >
> > ---------------------------------------------------------------------
>
>
> > To unsubscribe, e-mail: [EMAIL PROTECTED]
> > For additional commands, e-mail: [EMAIL PROTECTED]
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
