Am Freitag, den 26.10.2007, 11:34 +0200 schrieb Carsten Ziegeler: > The api looks good to me, but :) I have some minor comments:
Thanks :-) I am currently working on a longer mail explaining the changes. But here is, what I have to say to this. > - RequestParameter and RPMap are in a sub package while RequestPathInfo > is not. As they both contain additional request information, I think > they should either be all three in the core package or all three in the > same sub package. How about placing all three into the o.a.s.request package ? > - I think we should move the request and response wrapper into a sub > package as usually a developer does not need them. True, but I would like to keep them in the same place. The respective Serlvet API wrappers are also in the same package as their interface counterparts. > > - RequestPathInfo#getSelector(int) is imho not need. To get the number > of selectors I have to call getSelectors() which returns all and if I > want to iterate of the selectors I can just directly call getSelectors(). Agreed. This method is probably not worth it :-) > - I'm not sure if "helpers" is a good name for its contents (but I'm > currently lacking a better name) This name is inherited from the microsling project because I didn't have a better name either and I didn't want to place the contents in the o.a.s root package. Regards Felix
