[
https://issues.apache.org/jira/browse/SLING-90?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12539923
]
Bertrand Delacretaz commented on SLING-90:
------------------------------------------
Patch committed in revision 591606, all tests pass.
Shawn, thanks very much for providing a complete patch with tests + docs, that
makes the committer's life so much easier!
Two comments:
1) Having to write
resource.getItem().getProperty("text").getString()
in Ruby feels weird, I don't know JRuby well but I assume we could provide
wrappers to make this more Ruby-like, like the
ScriptableNode/ScriptableResource wrappers that Lars provided for javascript.
2) Is there a particular reason to create a PrintStream that eats Exceptions in
ErbScriptEngine? All kinds of red lights start blinking in my head when I see
this ;-)
> Add support for creating Ruby templates
> ---------------------------------------
>
> Key: SLING-90
> URL: https://issues.apache.org/jira/browse/SLING-90
> Project: Sling
> Issue Type: Improvement
> Components: microsling
> Reporter: Padraic Hannon
> Assignee: Felix Meschberger
> Attachments: ruby_passed_int_tests.patch
>
>
> By adding support for ruby scripted templates microsling could deal with
> adding dynamic mixins, which is something that java has a hard time with.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
