On Nov 27, 2007, at 5:30 AM, Felix Meschberger wrote:
Hi,
Am Dienstag, den 27.11.2007, 14:59 +0200 schrieb Jukka Zitting:
What's the patched Jasper version/revision? It would help if we could
see how extensive the Jasper changes are.
The base version was 5.5.20. The changes involved touching quite a few
classes.
I'm sure Jasper has also some other use cases where it would be
useful
to customize how the transpilation results are stored.
Not sure, at least given the response to my message to the tomcat list
[1].
Assuming you mean
http://markmail.org/message/3wzlksqjrfsv3pqc
I don't think that qualifies as contributing the patches upstream.
Let's start with a diff from the original and see if all of those
changes are necessary.
I think we may be starting with a solution to the wrong problem.
The problem that our users care about is that the cached class files
correspond to the currently active view, such that the class files
are marked invalid (or replaced) when the corresponding source
within JCR is changed. A bonus feature might be to store the class
files within the repository such that that they don't need to be
regenerated, but some customers (those without terabyte storage)
might not want that feature or may want to limit it to a small set
of recent versions.
We should be able to do both with a filesystem cache that is specific
to Jasper's class generation but with a layout that can be calculated
or stored as a property within the JCR "page" hierarchy. We can then
present a JCR interface to the pages such that the classes operate as
an intermediate cache (mapped by JCR) rather than being stored within
the repository itself. This should be a safe option given that we
don't want the class files to be "authored" directly and we do have
central control over their generation.
OTOH, I don't have a problem with forking jasper provided that the
forked copy is not mistaken for the Tomcat project's copy. That
means moving it to a different class location (not org/apache/jasper)
and documenting the tag or revision number for comparison to the
originals. Tomcat is free to adopt those changes at a later date.
....Roy
