Hi, Am Donnerstag, den 29.11.2007, 15:37 +0100 schrieb Bertrand Delacretaz: > On Nov 29, 2007 3:10 PM, Felix Meschberger <[EMAIL PROTECTED]> wrote: > > > ...While it is probably useful in certain situations to have the session > > available, I am not so sure, whether this should be documented and > > become part of the API or whether we should just have it. ... > > For microsling the JCR Session is required in several places, and > before this change it was acquired in an ugly way.
We will definitely have the same issue in Sling as soon as we merge the super-duper default servlet from microsling into Sling. > If it is needed in Sling as well, we could either add a > getJcrSession() method to SlingHttpServletRequest, or at least make > the attribute name a constant to expose its use. I am somewhat reluctant to creating such a method in the API because IMHO the main entry point to Resources is the ResourceResolver. Rather I would define a attribute name as a constant in Sling and microsling and document as part of the implementation documentation. The attribute should not be part of the Sling API itself. Regards Felix
