[
https://issues.apache.org/jira/browse/SLING-327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12578790#action_12578790
]
Felix Meschberger commented on SLING-327:
-----------------------------------------
In Rev. 637125 I committed a fix, which applies the same exception checking as
for regular (Credentials based) login when acquiring the anonymous session.
After exception handling authentication checking returns with failure.
So, when the repository is in a strange state - available yet not available -
or the session pool is fully used or something else altogether - no
authentication prompt is displayed.
Bertrand, can you please verify whether this is what you needed ? Thanks.
> SingAuthenticator: improve Repository sanity check
> --------------------------------------------------
>
> Key: SLING-327
> URL: https://issues.apache.org/jira/browse/SLING-327
> Project: Sling
> Issue Type: Improvement
> Reporter: Bertrand Delacretaz
> Priority: Minor
> Attachments: SLING-327.patch
>
>
> Currently the SlingAuthenticator sometimes behaves in funny ways if the
> Repository is not available, or not accepting logins for some reason. If
> anonymous access is allowed, for example, a login box might appear if the
> repository becomes unavailable, which makes things confusing.
> The attached patch improves the situation by verifying that an admin session
> can be obtained from the Repository, and throws MissingRepositoryException if
> not.
> This should allow better handling of Repository problems in higher
> application layers.
> I'm not sure about all the implications - can we assume that an admin session
> is required for things to work?
> Please review the patch before I apply it, or feel free to apply it, as I'll
> be mostly offline until after Easter
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
