Hi,

Am Freitag, den 04.04.2008, 20:36 +0200 schrieb Philipp Koch:
> so, why don't you introduce some kind of flag that will specify the
> required behaviour: checkin or not?

Same time - same thinking ;-)

Regards
Felix


> 
> regards,
> philipp
> 
> On Fri, Apr 4, 2008 at 7:17 PM, Tobias Bocanegra
> <[EMAIL PROTECTED]> wrote:
> >
> > >  while working with Sing I noticed that nodes declaring mixin node type
> >  > mix:versionable are not checked in when the initial content is loaded.
> >  >
> >  >  This is somehow unexpected to me and can lead to some trouble if you 
> > rely
> >  > on versioning. I propose to change this so that versionable nodes will be
> >  > checked in when initial content is loaded. First I started thinking 
> > about an
> >  > additional property in the content definition, but this is maybe a bit 
> > ugly
> >  > as it results in content definitions that mix real content with 
> > information
> >  > how to handle it.
> >  >
> >  >  Thus I changed the Loader implementation. it now checks in all 
> > versionable
> >  > nodes at the end of the content loading process. For that you need to add
> >  > mix:versionable explicitly in the content definition file. It is not 
> > enough
> >  > to declare a primary node type that defines mix:versionable, which in my
> >  > implementation leads to the same results as before.
> >  >
> >  >  If the team agrees with the proposed changes, I will add an according 
> > JIRA
> >  > issue and patch.
> >  i'm not sure if this is correct. is your requirement that the initial
> >  content already has a version or that the nodes are checked-in ?
> >
> >  i think it really depends on the application that needs the content if
> >  it should be checked in or not.
> >  --
> >  toby
> >

Reply via email to