[ 
https://issues.apache.org/jira/browse/SLING-365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12586436#action_12586436
 ] 

Felix Meschberger commented on SLING-365:
-----------------------------------------

Basically, I think the patch is ok. Just two minor notes:

(1) I do not like introducing another manifest header, rather I would go the 
OSGi way of defining a header parameter, such as:

     <Sling-Install-Content>
           SLING-INF/content;checkin=false,
           SLING-INF/checkedin;checkin=true
     </Sling-Install-Content>

I can take care of that one.

(2) I think checking the property to be set using the node type collection is 
too expensive and does not work for residuals. Rather I would try-catch setting 
the property and in case of succes check whether the property just set is in 
fact not protected.

Will adapt this while checkin the patch.

> Checkin versionable nodes in initial content
> --------------------------------------------
>
>                 Key: SLING-365
>                 URL: https://issues.apache.org/jira/browse/SLING-365
>             Project: Sling
>          Issue Type: Improvement
>          Components: Resource
>            Reporter: Alexander Saar
>         Attachments: checkin-initial-content.diff
>
>
> As discussed in [1] a bundle developer should be able to decide wether a 
> versionable node in his initial content should be checked in after the 
> content is imported or not.
> [1] http://www.mail-archive.com/[email protected]/msg03804.html

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to