[
https://issues.apache.org/jira/browse/SLING-533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12605237#action_12605237
]
Alexander Klimetschek commented on SLING-533:
---------------------------------------------
I tested it with a simple HTML file with different forms testing different
cases (one value, multiple values, typehint set/not set) and it works so far
(only Strings tested ATM).
Now I am wondering how to automate this: the tests in the servlets/post module
are purely based on a mocked (Sling) servlet request class. Using an actual
HTML form is a better documentation IMHO - but it is also more of a larger
integration test than a unit test.
> Support multi-value type hints (eg. @TypeHint=String[])
> -------------------------------------------------------
>
> Key: SLING-533
> URL: https://issues.apache.org/jira/browse/SLING-533
> Project: Sling
> Issue Type: New Feature
> Components: Servlets Post
> Reporter: Alexander Klimetschek
> Assignee: Carsten Ziegeler
> Fix For: 2.0.1
>
>
> As discussed in SLING-522, when posting a single value to a property that
> should be multi-valued, an extension to the @TypeHint is needed that allows
> the explicit definition of a multi-value type. For example, for Strings this
> would be @TypeHint=String[].
> Based on a quick look at the code, it should happen in
> o.a.s.servlets.post.impl.helper.SlingPropertyValueHandler.setPropertyAsIs().
> First of all the parsing of the getTypeHint() must be changed to look for an
> ending [] first, and then this "isMultiValued" information must be used to
> call the multi-value version of setProperty() in all cases (values.length >=
> 0).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
