[
https://issues.apache.org/jira/browse/SLING-475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12611927#action_12611927
]
Bertrand Delacretaz commented on SLING-475:
-------------------------------------------
Thanks for your patch - I had a look and it contains too many files:
pom.xml
launchpad/app/foo/image.JPG
launchpad/app/foo/bar/html.jsp
launchpad/app/foo/bar/header.jsp
launchpad/app/foo/header/header.jsp
launchpad/apps/foo/bar/html.jsp
launchpad/apps/foo/header/header.jsp
launchpad/webapp/src/test/java/org/apache/sling/launchpad/webapp/integrationtest/SLING475Test.java
launchpad/webapp/src/test/resources/integration-test/include-test.jsp
launchpad/webapp/pom.xml
scripting/velocity/pom.xml
sling/threads/src/main/java/org/apache/sling/threads/impl/ExtendedThreadFactory.java
I think you only meant to make changes to those two files:
launchpad/webapp/src/test/java/org/apache/sling/launchpad/webapp/integrationtest/SLING475Test.java
launchpad/webapp/src/test/resources/integration-test/include-test.jsp
For next time, please include only the required files in your patch, in this
case you could for example create the patch using:
cd sling
svn diff launchpad/webapp > SLING-475.patch
To only take the launchpad/webapp code subtree for the patch.
I'll add another comment about the code.
> Create Integration tests for the sling:include tag
> --------------------------------------------------
>
> Key: SLING-475
> URL: https://issues.apache.org/jira/browse/SLING-475
> Project: Sling
> Issue Type: Sub-task
> Components: Scripting JSP
> Reporter: Felix Meschberger
> Attachments: SLING-475.patch
>
>
> Summary says it all ;-)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
