[
https://issues.apache.org/jira/browse/SLING-649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12629090#action_12629090
]
Felix Meschberger commented on SLING-649:
-----------------------------------------
Quickly skimming the code lets me assume you are right. I think, it would make
perfect sense to support the "default" value for checkboxes like you proposed,
just to be lenient.
Please note, though, that the value atribute is technically required for
type="checkbox" inputs by the HTML 4.0.1 spec [1]
[1] http://www.w3.org/TR/html401/interact/forms.html#h-17.4
> checkboxes not handled by SlingPostServlet
> ------------------------------------------
>
> Key: SLING-649
> URL: https://issues.apache.org/jira/browse/SLING-649
> Project: Sling
> Issue Type: Improvement
> Components: Servlets Post
> Environment: Ubuntu AMD64 FF3
> Reporter: Renaud Richardet
> Priority: Minor
>
> I am trying to use checkboxes with the SlingPostServlet, as described in
> http://incubator.apache.org/sling/site/manipulating-content-the-slingpostservlet.html
> <form method="POST" action="/content/page/first">
> <input type="text" name="width" />
> <input type="hidden" name="[EMAIL PROTECTED]" value="Long" />
> <input type="checkbox" name="checked" />
> <input type="hidden" name="[EMAIL PROTECTED]" value="Boolean" />
> ...
> <input type="Submit" />
> </form>
> All elements work fine, excepte the checkbox: the "checked" node property is
> always set to false in JCR after a POST. Can anyone confirm?
> I guess it's because the POST request parameters are:
> width 1234
> [EMAIL PROTECTED] Long
> checked on
> [EMAIL PROTECTED] Boolean
> So, the passed checkbox parameter is "on" instead of "true"
> I guess I would have to modify SlingPropertyValueHandler.setPropertyAsIs() to
> handle "on" values as "true" if @TypeHint is Boolean. Similar to how dates
> values are handled if @TypeHint = date.
> If it's the right way to go, I will create a patch.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
