[
https://issues.apache.org/jira/browse/SLING-673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12634836#action_12634836
]
Felix Meschberger commented on SLING-673:
-----------------------------------------
Thanks for contributing this. Sounds great. In fact this would complement
another blog sample pending addition showing the multiple options provided by
Sling to reach the same goal.
However, I have some remarks.
> Note that the thumbnail generator bundle uses JAI libraries
I cannot confirm this. It uses ImageIO (part of Java API since 1.4) and Java2D
(also part of the Java API).
Nevertheless, I have some issues with this contributions and would object to
accept it as it stands now:
* No file has the ASF license header
* The Java classes are in com.day packages
* It is just a code dump .. What should we do with this ?
* What is the marker interface ImageListenerService intended for ?
As a fix I suggest the following:
* Move the Java Classes to org.apache.sling.samples.blog.ecma (the other blog
sample would be blog.jsp)
* Add ASF license headers
* Create a single bundle of the files with correct NOTICE/LICENSE attributions.
The scripts could be loaded into the repository as initial content or (my
personal favourite, since it is just files) provided as Bundle-Resources.
Let me reiterate: I would love to accept this contribution as a sample. Thanks
for your comprehension.
> sample application that demonstartes .esp scripts and osgi bundles
> ------------------------------------------------------------------
>
> Key: SLING-673
> URL: https://issues.apache.org/jira/browse/SLING-673
> Project: Sling
> Issue Type: Improvement
> Components: Samples
> Reporter: Michael Marth
> Attachments: myblog.zip
>
>
> A little blog sample application that can be included with the Sling samples.
> It includes some esp scripts and an OSGi bundle that generates thumbnails
> from uploaded images. A Readme file is provided with further information.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
