Hi Mark, Marc Speck schrieb: > Thanks for the feedback, Bertrand. I'm happy to provide this minor patch. > However, it seems the new proposal of Felix about ResourceResolverFactory, > http://cwiki.apache.org/SLING/add-resourceresolverfactory-service-interface.html, > also allows my use case. So should you find agreement on the proposal > and > implement it in the next weeks, I'm fine with waiting for it.
In fact, your initial message prompted me to finally publicize the proposal ;-) So, I didn't want to answer to your request too early. Since, the proposal is most probably not going to be implemented within a day or two ;-), your proposal makes absolute sense to me. (In fact I have implemented some prototype in my workspace to look at it ;-) ). My propotype just extends the AuthenticationInfo class by adding another constructor taking the workspace name and a new getWorkspaceName method. Would you mind to create a JIRA for this ? Then I will ASAP commit this extension. Thinking of compatibility: It think we can easily turn the AuthenticationInfo class into a Map<String, Object> suitable for the proposed ResourceProviderFactory.getResourceProvider method for it to be used by AuthenticationHandler implementations. So this proposal can still be supported even with ResourceResolverFactory implemented. Regards Felix > > Marc > > > > > On Tue, Nov 11, 2008 at 12:10 PM, Bertrand Delacretaz < > [EMAIL PROTECTED]> wrote: > >> Hi Marc, >> >> On Fri, Nov 7, 2008 at 3:39 PM, Marc Speck <[EMAIL PROTECTED]> wrote: >> >>> ....We thought about adding the workspaceName to >>> AuthenticationInfo(String authType, Credentials credentials, String >>> workspaceName).... >> Ok, as long as you keep the existing constructor. >> >>> ... And then add it in SlingAuthenticator: >>> >>> ... Session session = getRepository().login( >>> - authInfo.getCredentials(), null); >>> + authInfo.getCredentials(), >>> authInfo.getWorkspaceName());... >> Sounds good to me! >> >> -Bertrand >> >
